| Summary: | Fix QNX Qt build by enabling JIT. | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Sergio Martins <sergio.martins> | ||||||||||
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | benjamin, hausmann, milian.wolff, ojan, philn, webkit.review.bot, xan.lopez | ||||||||||
| Priority: | P2 | ||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Bug Depends on: | |||||||||||||
| Bug Blocks: | 74040 | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Sergio Martins
2012-11-20 04:12:36 PST
Created attachment 175187 [details]
Patch
Created attachment 175188 [details]
Patch
This is related to https://bugs.webkit.org/show_bug.cgi?id=98031 ( LLint failure ) Comment on attachment 175188 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=175188&action=review > Source/WTF/wtf/Platform.h:1008 > +#if !defined(ENABLE_YARR_JIT) && (ENABLE(JIT) || ENABLE(LLINT_C_LOOP)) && !PLATFORM(CHROMIUM) && !(OS(QNX) && PLATFORM(QT)) This change is missing a ChangeLog and I don't understand why this part is necessary (no changelog ;) If you enable the JIT, why not also enable YARR_JIT? Seems like the Changelog changes weren't uploaded Created attachment 177325 [details]
Patch
Comment on attachment 177325 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=177325&action=review > Source/WTF/wtf/Platform.h:900 > + && !(OS(QNX) && !PLATFORM(QT)) // We use jit in qnx qt jit -> JIT. qnx -> QNX. qt -> Qt And the use of C++ comments in this header file breaks the build of any C files, as the Gtk EWS indicated. Created attachment 179011 [details]
Patch
Comment on attachment 179011 [details] Patch Clearing flags on attachment: 179011 Committed r137449: <http://trac.webkit.org/changeset/137449> All reviewed patches have been landed. Closing bug. |