Summary: | TestExpecations ignores entry with dot in folder name | ||
---|---|---|---|
Product: | WebKit | Reporter: | Yury Semikhatsky <yurys> |
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
Status: | RESOLVED WONTFIX | ||
Severity: | Normal | CC: | dpranke |
Priority: | P2 | ||
Version: | 528+ (Nightly build) | ||
Hardware: | Unspecified | ||
OS: | Unspecified |
Description
Yury Semikhatsky
2012-11-20 02:20:42 PST
There is already a line for svg/carto.net/colourpicker.svg on line 1975; I suspect the newly added line was being ignored (and you were probably getting warnings telling you about this, or at least you should've been). I just tested this w/o the duplicate line and it worked fine (and indeed, the original line works fine as well). Let me know if I've missed something? (In reply to comment #1) > There is already a line for svg/carto.net/colourpicker.svg on line 1975; I suspect the newly added line was being ignored (and you were probably getting warnings telling you about this, or at least you should've been). > I started with fixing duplicate entries that lint complained about and then noticed that the new expectation didn't work. > I just tested this w/o the duplicate line and it worked fine (and indeed, the original line works fine as well). > > Let me know if I've missed something? In my scenario I deleted everything but the following line from LayoutTests/platform/chromium/TestExpectations: webkit.org/b/102724 svg/carto.net/colourpicker.svg [ Crash ] and than ran single test: ./webkit/tools/layout_tests/run_webkit_tests.sh --target Debug svg/carto_net/colourpicker.svg The output was as I described so I don't think the problem is duplicate entries. (In reply to comment #2) > (In reply to comment #1) > > There is already a line for svg/carto.net/colourpicker.svg on line 1975; I suspect the newly added line was being ignored (and you were probably getting warnings telling you about this, or at least you should've been). > > > I started with fixing duplicate entries that lint complained about and then noticed that the new expectation didn't work. > > > I just tested this w/o the duplicate line and it worked fine (and indeed, the original line works fine as well). > > > > Let me know if I've missed something? > > In my scenario I deleted everything but the following line from LayoutTests/platform/chromium/TestExpectations: > > webkit.org/b/102724 svg/carto.net/colourpicker.svg [ Crash ] > > and than ran single test: > ./webkit/tools/layout_tests/run_webkit_tests.sh --target Debug svg/carto_net/colourpicker.svg > > The output was as I described so I don't think the problem is duplicate entries. After some debugging it turned out that the expectation in LayoutTests/platform/chromium/TestExpectations was overwritten by another one in src/skia/skia_test_expectations.txt I think it would be nice to inform user that expectations in one file are overwritten by another file. |