Bug 102747

Summary: In CodeGeneratorV8.pm, we should rename $dataNode to $interface
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: WebCore JavaScriptAssignee: Kentaro Hara <haraken>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, japhet, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch abarth: review+, webkit.review.bot: commit-queue-

Kentaro Hara
Reported 2012-11-19 17:29:45 PST
$dataNode is misnamed. It should be $interface.
Attachments
Patch (65.33 KB, patch)
2012-11-19 17:30 PST, Kentaro Hara 		abarth: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2012-11-19 17:30:53 PST
Created attachment 175092 [details] Patch
WebKit Review Bot
Comment 2 2012-11-19 18:46:03 PST
Comment on attachment 175092 [details] Patch Rejecting attachment 175092 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: commit-queue/Source/WebKit/chromium/third_party/v8-i18n --revision 157 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 51>At revision 157. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/14901418
Kentaro Hara
Comment 3 2012-11-19 20:26:52 PST
Committed r135239: <http://trac.webkit.org/changeset/135239>
Note You need to log in before you can comment on or make changes to this bug.