Bug 102733

Summary: IndexedDB: remove IDBDatabaseBackendInterface::transaction()
Product: WebKit Reporter: Alec Flett <alecflett>
Component: WebCore Misc.Assignee: Alec Flett <alecflett>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, dgrogan, fishd, jamesr, jsbell, tkent+wkapi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 102732    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch for landing
none
Patch for landing none

Alec Flett
Reported 2012-11-19 16:13:08 PST
Once the backend is passing transaction ids all the way through to the backend, remove supporting code.
Attachments
Patch (10.22 KB, patch)
2012-11-27 11:57 PST, Alec Flett 		no flags
DetailsFormatted DiffDiff
Patch (13.61 KB, patch)
2012-11-29 15:10 PST, Alec Flett 		no flags
DetailsFormatted DiffDiff
Patch (13.61 KB, patch)
2012-11-29 15:42 PST, Alec Flett 		no flags
DetailsFormatted DiffDiff
Patch for landing (12.42 KB, patch)
2012-11-30 10:12 PST, Alec Flett 		no flags
DetailsFormatted DiffDiff
Patch for landing (12.63 KB, patch)
2012-12-03 11:19 PST, Alec Flett 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Joshua Bell
Comment 1 2012-11-20 09:31:09 PST
This issue should be about IDBDatabaseBackendInterface::transaction(), right?
Alec Flett
Comment 2 2012-11-27 11:57:01 PST
Created attachment 176315 [details] Patch
WebKit Review Bot
Comment 3 2012-11-27 12:00:51 PST
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Alec Flett
Comment 4 2012-11-27 12:08:46 PST
fishd@ - r? The other half of bug 102730 that you reviewed on monday
Alec Flett
Comment 5 2012-11-29 15:10:09 PST
Created attachment 176827 [details] Patch
Alec Flett
Comment 6 2012-11-29 15:42:00 PST
Created attachment 176835 [details] Patch
Alec Flett
Comment 7 2012-11-30 10:12:43 PST
Created attachment 176988 [details] Patch for landing
WebKit Review Bot
Comment 8 2012-12-02 03:10:49 PST
Comment on attachment 176988 [details] Patch for landing Rejecting attachment 176988 [details] from commit-queue. New failing tests: inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html Full output: http://queues.webkit.org/results/15100139
Alec Flett
Comment 9 2012-12-03 11:19:25 PST
Created attachment 177292 [details] Patch for landing
Alec Flett
Comment 10 2012-12-03 11:19:53 PST
I think the last test failure was a fluke. trying again..
WebKit Review Bot
Comment 11 2012-12-03 11:37:42 PST
Comment on attachment 177292 [details] Patch for landing Clearing flags on attachment: 177292 Committed r136423: <http://trac.webkit.org/changeset/136423>
WebKit Review Bot
Comment 12 2012-12-03 11:37:46 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.