Bug 102693

Summary: webkitpy unit tests should run serially when checking code coverage
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dpranke, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch dpranke: review+, dpranke: commit-queue-

Zan Dobersek
Reported 2012-11-19 08:32:58 PST
webkitpy unit tests should run serially when checking code coverage
Attachments
Patch (1.53 KB, patch)
2012-11-19 08:35 PST, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch (2.74 KB, patch)
2012-11-19 08:54 PST, Zan Dobersek 		dpranke: review+
dpranke: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2012-11-19 08:35:21 PST
Created attachment 174990 [details] Patch
Zan Dobersek
Comment 2 2012-11-19 08:54:27 PST
Created attachment 174993 [details] Patch
Dirk Pranke
Comment 3 2012-11-19 11:57:13 PST
Comment on attachment 174993 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=174993&action=review Thanks for looking at this! I had noticed this but hadn't gotten around to posting a patch. > Tools/Scripts/webkitpy/test/main.py:138 > + self.printer.write("Checking code coverage, so running things serially\n") What's wrong with using _log.warning() for this and the above?
Zan Dobersek
Comment 4 2012-11-20 00:17:54 PST
Comment on attachment 174993 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=174993&action=review >> Tools/Scripts/webkitpy/test/main.py:138 >> + self.printer.write("Checking code coverage, so running things serially\n") > > What's wrong with using _log.warning() for this and the above? It skews the output a bit, i.e. the warning is written out on the same line as the 'Checking autoinstalled packages ...' update. 'Checking autoinstalled packages ...Checking code coverage, so running things serially' I'll land this with the code using _log.warning and create a patch with a better solution.
Zan Dobersek
Comment 5 2012-11-20 00:20:36 PST
Committed r135264: <http://trac.webkit.org/changeset/135264>
Note You need to log in before you can comment on or make changes to this bug.