Bug 102671

Summary: Rename idlDocument::classes to idlDocument::interfaces in the IDL parser
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: WebCore JavaScriptAssignee: Kentaro Hara <haraken>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, darin, japhet, mjs, sam, timothy, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Kentaro Hara
Reported 2012-11-19 04:02:24 PST
Most part of code generators use 'interface'. The spec uses 'interface'. Thus, the IDL parser should use 'interface' instead of 'class'.
Attachments
Patch (11.11 KB, patch)
2012-11-19 04:07 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
Patch (14.34 KB, patch)
2012-11-19 04:22 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2012-11-19 04:07:53 PST
Created attachment 174944 [details] Patch
Kentaro Hara
Comment 2 2012-11-19 04:11:25 PST
If you have no objection, I'll replace $dataNode with $interfaceName in code generators. Currently code generators have the following code here and there, which doesn't make much sense: my $interfaceName = $dataNode->name; As this change will require a bunch of replacements, please stop me if you have any concern:-)
Kentaro Hara
Comment 3 2012-11-19 04:22:37 PST
Created attachment 174947 [details] Patch
Adam Barth
Comment 4 2012-11-19 12:02:56 PST
Comment on attachment 174947 [details] Patch This might break Apple's internal use of these scripts. We should be careful when landing it.
Adam Barth
Comment 5 2012-11-19 12:13:32 PST
@Timothy: This is another patch that might cause problems for Apple's internal use of these scripts.
Timothy Hatcher
Comment 6 2012-11-19 14:35:15 PST
This one is fine. We use generate-bindings.pl directly and not the CodeGenerator.pm. Thanks!
Adam Barth
Comment 7 2012-11-19 14:59:43 PST
Comment on attachment 174947 [details] Patch Great. Thanks!
WebKit Review Bot
Comment 8 2012-11-19 15:09:18 PST
Comment on attachment 174947 [details] Patch Clearing flags on attachment: 174947 Committed r135203: <http://trac.webkit.org/changeset/135203>
WebKit Review Bot
Comment 9 2012-11-19 15:09:22 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.