Bug 102651
| Summary: | [EFL] Fix assertion on processing ipc messages about network info | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Byungwoo Lee <bw80.lee> |
| Component: | WebKit EFL | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED WONTFIX | ||
| Severity: | Normal | CC: | cdumez, gyuyoung.kim, lucas.de.marchi, pnormand |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 131841 | ||
| Bug Blocks: | 100310 | ||
Byungwoo Lee
Need to fix assertion on processing ipc messages about network info.
This is the sub issue of Bug 100310.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Chris Dumez
Any update on this? Are you planning to write the patch or can I assign this bug to me?
Byungwoo Lee
Actually, I can't decide the solution for this.
In current implementation,
StartUpdating and StopUpdating messages of WebNetworkInfoManagerProxy are unified by WebNetworkInfoManager. (All WebPages share the IPC message, so WebProcess sent the IPC message without page destination ID)
But GetBandwidth and IsMetered is handled per WebPage. (WebProcess sends the IPC message with page destination ID, so the IPC messages need to be handled per WebPage)
To apply r132386,
1. IPC Messages of WebNetworkInfoManagerProxy need to be sorted.
(like geolocation IPC, WebPages share the StartUpdating/StopUpdating, and WebPageProxy have GetBandwidth and IsMetered message)
2. Change for WebProcess to send all the network info IPC messages with page destination ID, and all the messages will be handled per WebPage.
Personally, I prefer the first solution.
How about your opinion? Is there any other solution?