Bug 102642

Summary: Remove IDLStructure.pm
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: WebCore JavaScriptAssignee: Kentaro Hara <haraken>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, cgarcia, gyuyoung.kim, japhet, ossy, philn, rakuco, webkit-ews, webkit.review.bot, xan.lopez, zan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
patch for landing
none
patch for landing none

Kentaro Hara
Reported 2012-11-18 22:13:24 PST
Previously IDLStructure.pm was full of regular expressions to parse IDL files. Now a new IDL parser is implemented, IDLStructure.pm just contains several data structures for the IDL parser. We can move them to IDLParser.pm and thus remove IDLStructure.pm.
Attachments
Patch (21.79 KB, patch)
2012-11-18 22:14 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
patch for landing (22.65 KB, patch)
2012-11-18 23:05 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
patch for landing (26.25 KB, patch)
2012-11-19 01:35 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2012-11-18 22:14:46 PST
Created attachment 174891 [details] Patch
Adam Barth
Comment 2 2012-11-18 23:02:09 PST
Comment on attachment 174891 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=174891&action=review > Source/WebCore/bindings/scripts/IDLStructure.pm:-28 > -# Used to represent a parsed IDL document Don't you actually want to "svn rm" the whole file?
Kentaro Hara
Comment 3 2012-11-18 23:05:10 PST
Created attachment 174898 [details] patch for landing
Kentaro Hara
Comment 4 2012-11-18 23:05:39 PST
Comment on attachment 174898 [details] patch for landing Oops, removed IDLStructure.pm.
WebKit Review Bot
Comment 5 2012-11-18 23:34:14 PST
Comment on attachment 174898 [details] patch for landing Clearing flags on attachment: 174898 Committed r135114: <http://trac.webkit.org/changeset/135114>
WebKit Review Bot
Comment 6 2012-11-18 23:34:20 PST
All reviewed patches have been landed. Closing bug.
Csaba Osztrogonác
Comment 7 2012-11-19 00:31:42 PST
(In reply to comment #5) > (From update of attachment 174898 [details]) > Clearing flags on attachment: 174898 > > Committed r135114: <http://trac.webkit.org/changeset/135114> It broke the Qt build. Could you fix it?
Kentaro Hara
Comment 8 2012-11-19 00:34:34 PST
Sorry for the trouble. Looking.
Kentaro Hara
Comment 9 2012-11-19 00:43:36 PST
(In reply to comment #8) > Sorry for the trouble. Looking. hmm, I don't see the cause of the build error. I removed "IDLStructure" from all build files, including DerivedSources.pri, which is used by Qt. Let me revert the patch for now. I need to investigate the issue using the build bots before landing.
Kentaro Hara
Comment 10 2012-11-19 00:46:13 PST
Reverted r135114 for reason: it broke Qt build Committed r135123: <http://trac.webkit.org/changeset/135123>
Carlos Garcia Campos
Comment 11 2012-11-19 00:56:51 PST
It also broke GTK+ build there are references to IDLStructure.pm in Tools/WebKitTestRunner/GNUmakefile.am too
Kentaro Hara
Comment 12 2012-11-19 01:00:39 PST
(In reply to comment #11) > It also broke GTK+ build there are references to IDLStructure.pm in Tools/WebKitTestRunner/GNUmakefile.am too Ah, thanks! Will update the patch.
Early Warning System Bot
Comment 13 2012-11-19 01:19:21 PST
Comment on attachment 174898 [details] patch for landing Attachment 174898 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/14906109
Build Bot
Comment 14 2012-11-19 01:27:24 PST
Comment on attachment 174898 [details] patch for landing Attachment 174898 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/14903005
Kentaro Hara
Comment 15 2012-11-19 01:35:39 PST
Created attachment 174912 [details] patch for landing
WebKit Review Bot
Comment 16 2012-11-19 02:02:38 PST
Comment on attachment 174912 [details] patch for landing Clearing flags on attachment: 174912 Committed r135129: <http://trac.webkit.org/changeset/135129>
WebKit Review Bot
Comment 17 2012-11-19 02:02:45 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.