Bug 102624

Summary: Make RenderLayer::updateLayerPosition() private
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, eric, simon.fraser, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 105861, 125392    
Bug Blocks:    
Attachments:
Description Flags
Patch rniwa: review+, webkit.review.bot: commit-queue-

Simon Fraser (smfr)
Reported 2012-11-18 17:14:28 PST
Make RenderLayer::updateLayerPosition() private
Attachments
Patch (5.99 KB, patch)
2012-11-18 17:18 PST, Simon Fraser (smfr) 		rniwa: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2012-11-18 17:18:53 PST
Created attachment 174863 [details] Patch
Ryosuke Niwa
Comment 2 2012-11-18 19:47:23 PST
Comment on attachment 174863 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=174863&action=review Looks right to me. > Source/WebCore/dom/MouseRelatedEvent.cpp:167 > if (RenderObject* r = targetNode->renderer()) { The code right beneath this calls absoluteToLocal!
WebKit Review Bot
Comment 3 2012-11-18 20:26:10 PST
Comment on attachment 174863 [details] Patch Attachment 174863 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14910026 New failing tests: fast/events/stopPropagation-submit.html
Simon Fraser (smfr)
Comment 4 2012-11-30 15:01:39 PST
http://trac.webkit.org/changeset/136280
Eric Seidel (no email)
Comment 5 2012-12-30 13:59:10 PST
I believe this caused bug 102624 (assuming I ran git-bisect correctly).
Eric Seidel (no email)
Comment 6 2012-12-30 13:59:28 PST
Sorry, I meant bug 105861.
Note You need to log in before you can comment on or make changes to this bug.