Bug 102622

Summary: Enable sub-pixel tests on Mac
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: zalan <zalan>
Severity: Normal CC: allan.jensen, eae, jonlee, leviw, simon.fraser, webkit.review.bot, zalan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 85532    
Description Flags
Patch krit: review+

Description Simon Fraser (smfr) 2012-11-18 16:31:45 PST
Enable sub-pixel tests on Mac
Comment 1 Simon Fraser (smfr) 2012-11-18 16:33:46 PST
Created attachment 174860 [details]
Comment 2 WebKit Review Bot 2012-11-18 16:36:04 PST
Attachment 174860 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1
LayoutTests/platform/gtk-wk2/TestExpectations:241:  Test lacks BUG modifier.  [test/expectations] [5]
Total errors found: 1 in 9 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Dirk Schulze 2013-02-16 00:12:19 PST
Comment on attachment 174860 [details]

LGTM. r=me
Comment 4 Allan Sandfeld Jensen 2013-04-17 06:06:03 PDT
Forgot to land?
Comment 5 Simon Fraser (smfr) 2013-04-17 09:30:00 PDT
We're going to turn subpixel off again.
Comment 6 Jon Lee 2014-01-14 00:17:17 PST

*** This bug has been marked as a duplicate of bug 126283 ***
Comment 7 Alexey Proskuryakov 2014-04-05 17:30:19 PDT
Subpixel tests are still skipped in platform/mac-wk2/TestExpectations:

# Fail until SUBPIXEL_LAYOUT is enabled
# https://bugs.webkit.org/show_bug.cgi?id=85532