Bug 102590

Summary: Web Inspector: Remove unused ConsoleMessage constructor.
Product: WebKit Reporter: Mike West <mkwst>
Component: Web Inspector (Deprecated)Assignee: Mike West <mkwst>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Mike West
Reported 2012-11-17 08:36:39 PST
'ConsoleMessage(MessageSource, MessageType, MessageLevel, const String& m, const String& responseUrl, unsigned long requestIdentifier)' is unused, so far as I can tell.
Attachments
Patch (2.58 KB, patch)
2012-11-17 08:45 PST, Mike West 		no flags
DetailsFormatted DiffDiff
Patch (2.59 KB, patch)
2012-11-18 12:27 PST, Mike West 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mike West
Comment 1 2012-11-17 08:45:21 PST
Created attachment 174819 [details] Patch
WebKit Review Bot
Comment 2 2012-11-17 08:47:31 PST
Attachment 174819 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/ChangeLog:8: Line contains tab character. [whitespace/tab] [5] Source/WebCore/ChangeLog:9: Line contains tab character. [whitespace/tab] [5] Source/WebCore/ChangeLog:14: Line contains tab character. [whitespace/tab] [5] Total errors found: 3 in 1 files If any of these errors are false positives, please file a bug against check-webkit-style.
Mike West
Comment 3 2012-11-18 12:27:21 PST
Created attachment 174853 [details] Patch
Brent Fulgham
Comment 4 2012-11-18 21:35:52 PST
Comment on attachment 174853 [details] Patch Yay! Dead code removal. R=me.
WebKit Review Bot
Comment 5 2012-11-18 21:41:18 PST
Comment on attachment 174853 [details] Patch Clearing flags on attachment: 174853 Committed r135107: <http://trac.webkit.org/changeset/135107>
WebKit Review Bot
Comment 6 2012-11-18 21:41:22 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.