Summary: | Text Autosizing: Skip blocks with background images | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | John Mellor <johnme> | ||||||||
Component: | Layout and Rendering | Assignee: | timvolodine | ||||||||
Status: | RESOLVED WONTFIX | ||||||||||
Severity: | Normal | CC: | avayvod, dbates, eric, johnme, kenneth, ojan.autocc, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
URL: | http://www.flickr.com/tour/#section=share-your-photos | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 84186, 102509 | ||||||||||
Attachments: |
|
Description
John Mellor
2012-11-16 07:10:49 PST
Created attachment 174678 [details]
Screenshot of flickr.com list markers
Hmm, and I've been talking about blocks with fixed-height background images, but this particular example is of course an inline span with a fixed-height background image - so I guess it's not enough to do this check for blocks only. Though disabling Text Autosizing for part but not all of a line is really bad. So perhaps the scaling up approach is more practical... Created attachment 180529 [details]
Patch
Comment on attachment 180529 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=180529&action=review > Source/WebCore/ChangeLog:9 > + Prevent autosizing of containers containing elements with background images. > + It is always good to write the reasoning behind such a change Created attachment 180897 [details]
Patch
uploaded a new patch with a more detailed description as suggested by Kenneth. (looks like lost the review+ tag in the process) Code-wise this seems fine (possibly a slight shame to introduce a separate tree traveral rather than reusing the one from containerContainsOneOfTags, but the run time will still be O(n), and I guess it's arguably clearer). However Tim and I looked at the effect this has on websites and, while it improves the rendering of a lot of sites, it also worsens the rendering of a lot of other sites. It's quite common to include background-images inline (e.g. on a span's ::before or ::after pseudo-element), and in these cases we were no longer autosizing whole paragraphs, that did in fact require autosizing. Tim's going to try tweaking this so it only skips blocks containing elements with background images if those elements also contain text. De-prioritizing this slightly though, as it's not as urgent as some other Text Autosizing issues. Comment on attachment 180897 [details]
Patch
Clearing review flag on patches from before 2014. If this patch is still relevant, please reset the r? flag.
Marking this bug Resolved WontFix because the TEXT_AUTOSIZING feature was removed in <https://trac.webkit.org/changeset/206119> (bug #162167). See bug 84186, comment 32 for more details. |