Summary: | Remove $outputDir and $outputHeadersDir from global variables of code generators | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kentaro Hara <haraken> | ||||||||||
Component: | WebCore JavaScript | Assignee: | Kentaro Hara <haraken> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | abarth, japhet, jussi.kukkonen, ossy, philn, thorton, timothy, webkit-ews, webkit.review.bot, xan.lopez | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Kentaro Hara
2012-11-16 06:02:38 PST
Created attachment 174662 [details]
Patch
Comment on attachment 174662 [details] Patch Attachment 174662 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/14858472 Comment on attachment 174662 [details] Patch Attachment 174662 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/14873136 Comment on attachment 174662 [details]
Patch
Looks like you have come compile problems...
Created attachment 174955 [details]
another try
Comment on attachment 174955 [details] another try Attachment 174955 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/14901167 Created attachment 174958 [details]
another try
Comment on attachment 174958 [details]
another try
Now build bots look happy. r?
Based on what timothy wrote in another bug, this shouldn't be a problem for the Safari builds because they don't use CodeGenerator.pm. Created attachment 175311 [details]
patch for landing
Comment on attachment 175311 [details] patch for landing Clearing flags on attachment: 175311 Committed r135340: <http://trac.webkit.org/changeset/135340> All reviewed patches have been landed. Closing bug. (In reply to comment #9) > Based on what timothy wrote in another bug, this shouldn't be a problem for the Safari builds because they don't use CodeGenerator.pm. Erg, this broke stuff too. I'll look and see if it's easy to fix, otherwise I might have to roll this out till next week. (In reply to comment #13) > (In reply to comment #9) > > Based on what timothy wrote in another bug, this shouldn't be a problem for the Safari builds because they don't use CodeGenerator.pm. > > Erg, this broke stuff too. I'll look and see if it's easy to fix, otherwise I might have to roll this out till next week. sorry, I can roll out the patch. Ping me if needed. Reverted r135340 for reason: It broke Safari's internal build Committed r135387: <http://trac.webkit.org/changeset/135387> I will reland the patch next week when Apple guys can take care of Safari's internal build. (In reply to comment #15) > Reverted r135340 for reason: > > It broke Safari's internal build > > Committed r135387: <http://trac.webkit.org/changeset/135387> And the rollout broke the bining tests. Could you update it too? > Erg, this broke stuff too. I'm sorry this patch broke things. I must have misunderstood what you wrote in <https://bugs.webkit.org/show_bug.cgi?id=102671#c6>. :( It turns out we have two scripts that use WebCore binging scripts. One uses generate-bindings.pl. The other uses CodeGenerator.pm. Thanks for the clarification and your patience. More details. We have our own CodeGeneratorSafari.pm too. So we need to keep up will any changes to CodeGenerator.pm and its interface. I'm working on making this work with TOT WebCore now. Go ahead and land this again. I know the fixes we need to make. Comment on attachment 175311 [details] patch for landing Clearing flags on attachment: 175311 Committed r135426: <http://trac.webkit.org/changeset/135426> All reviewed patches have been landed. Closing bug. Thanks for the fix! |