Bug 102492

Summary:

Remove $outputDir and $outputHeadersDir from global variables of code generators

Product:

WebKit

Reporter:

Kentaro Hara <haraken>

Component:

WebCore JavaScript

Assignee:

Kentaro Hara <haraken>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, japhet, jussi.kukkonen, ossy, philn, thorton, timothy, webkit-ews, webkit.review.bot, xan.lopez

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
another try	none
another try	none
patch for landing	none

Kentaro Hara

Reported 2012-11-16 06:02:38 PST

$outputDir and $outputHeadersDir are used in WriteData() only. We don't need to use global variables for them.

Attachments
Patch (10.20 KB, patch) 2012-11-16 06:05 PST, Kentaro Hara	no flags	Details Formatted Diff Diff
another try (11.66 KB, patch) 2012-11-19 04:46 PST, Kentaro Hara	no flags	Details Formatted Diff Diff
another try (11.86 KB, patch) 2012-11-19 04:59 PST, Kentaro Hara	no flags	Details Formatted Diff Diff
patch for landing (11.99 KB, patch) 2012-11-20 17:23 PST, Kentaro Hara	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Kentaro Hara

Comment 1 2012-11-16 06:05:17 PST

Created attachment 174662 [details] Patch

Early Warning System Bot

Comment 2 2012-11-16 06:22:21 PST

Comment on attachment 174662 [details] Patch Attachment 174662 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/14858472

Build Bot

Comment 3 2012-11-16 06:53:04 PST

Comment on attachment 174662 [details] Patch Attachment 174662 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/14873136

Adam Barth

Comment 4 2012-11-16 09:32:18 PST

Comment on attachment 174662 [details] Patch Looks like you have come compile problems...

Kentaro Hara

Comment 5 2012-11-19 04:46:33 PST

Created attachment 174955 [details] another try

Early Warning System Bot

Comment 6 2012-11-19 04:57:05 PST

Comment on attachment 174955 [details] another try Attachment 174955 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/14901167

Kentaro Hara

Comment 7 2012-11-19 04:59:13 PST

Created attachment 174958 [details] another try

Kentaro Hara

Comment 8 2012-11-19 17:56:41 PST

Comment on attachment 174958 [details] another try Now build bots look happy. r?

Adam Barth

Comment 9 2012-11-20 16:39:58 PST

Based on what timothy wrote in another bug, this shouldn't be a problem for the Safari builds because they don't use CodeGenerator.pm.

Kentaro Hara

Comment 10 2012-11-20 17:23:15 PST

Created attachment 175311 [details] patch for landing

WebKit Review Bot

Comment 11 2012-11-20 18:33:39 PST

Comment on attachment 175311 [details] patch for landing Clearing flags on attachment: 175311 Committed r135340: <http://trac.webkit.org/changeset/135340>

WebKit Review Bot

Comment 12 2012-11-20 18:33:43 PST

All reviewed patches have been landed. Closing bug.

Tim Horton

Comment 13 2012-11-21 04:56:07 PST

(In reply to comment #9) > Based on what timothy wrote in another bug, this shouldn't be a problem for the Safari builds because they don't use CodeGenerator.pm. Erg, this broke stuff too. I'll look and see if it's easy to fix, otherwise I might have to roll this out till next week.

Kentaro Hara

Comment 14 2012-11-21 04:57:51 PST

(In reply to comment #13) > (In reply to comment #9) > > Based on what timothy wrote in another bug, this shouldn't be a problem for the Safari builds because they don't use CodeGenerator.pm. > > Erg, this broke stuff too. I'll look and see if it's easy to fix, otherwise I might have to roll this out till next week. sorry, I can roll out the patch. Ping me if needed.

Kentaro Hara

Comment 15 2012-11-21 05:01:39 PST

Reverted r135340 for reason: It broke Safari's internal build Committed r135387: <http://trac.webkit.org/changeset/135387>

Kentaro Hara

Comment 16 2012-11-21 05:02:28 PST

I will reland the patch next week when Apple guys can take care of Safari's internal build.

Csaba Osztrogonác

Comment 17 2012-11-21 07:03:22 PST

(In reply to comment #15) > Reverted r135340 for reason: > > It broke Safari's internal build > > Committed r135387: <http://trac.webkit.org/changeset/135387> And the rollout broke the bining tests. Could you update it too?

Adam Barth

Comment 18 2012-11-21 09:58:19 PST

> Erg, this broke stuff too. I'm sorry this patch broke things. I must have misunderstood what you wrote in <https://bugs.webkit.org/show_bug.cgi?id=102671#c6>. :(

Timothy Hatcher

Comment 19 2012-11-21 10:00:31 PST

It turns out we have two scripts that use WebCore binging scripts. One uses generate-bindings.pl. The other uses CodeGenerator.pm.

Adam Barth

Comment 20 2012-11-21 10:39:25 PST

Thanks for the clarification and your patience.

Timothy Hatcher

Comment 21 2012-11-21 11:19:13 PST

More details. We have our own CodeGeneratorSafari.pm too. So we need to keep up will any changes to CodeGenerator.pm and its interface. I'm working on making this work with TOT WebCore now.

Timothy Hatcher

Comment 22 2012-11-21 12:03:17 PST

Go ahead and land this again. I know the fixes we need to make.

WebKit Review Bot

Comment 23 2012-11-21 12:30:03 PST

Comment on attachment 175311 [details] patch for landing Clearing flags on attachment: 175311 Committed r135426: <http://trac.webkit.org/changeset/135426>

WebKit Review Bot

Comment 24 2012-11-21 12:30:08 PST

All reviewed patches have been landed. Closing bug.

Kentaro Hara

Comment 25 2012-11-21 14:13:19 PST

Thanks for the fix!

Note You need to log in before you can comment on or make changes to this bug.