| Summary: | When releasing a CGImage, we should remove it from the subimage cache too. | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yongjun Zhang <yongjun_zhang> | ||||||||||||
| Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | benjamin, buildbot, darin, ddkilzer, dglazkov, rniwa, webkit.review.bot | ||||||||||||
| Priority: | P2 | ||||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||||
| Hardware: | Mac | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Yongjun Zhang
2012-11-15 18:17:02 PST
Created attachment 174586 [details]
Move SubimageCacheWithTimer to separate files.
Comment on attachment 174586 [details] Move SubimageCacheWithTimer to separate files. Attachment 174586 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/14857504 Created attachment 174607 [details]
Fix win build break.
Comment on attachment 174607 [details] Fix win build break. Attachment 174607 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14844802 New failing tests: inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html Created attachment 174739 [details]
Re-submit the patch for bots to pick up.
Part of <rdar://problem/12701759> Created attachment 186934 [details]
Move subimage cache code into separate h/cpp file.
Comment on attachment 186934 [details] Move subimage cache code into separate h/cpp file. Attachment 186934 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://queues.webkit.org/results/16398419 New failing tests: http/tests/cache/cached-main-resource.html Comment on attachment 186934 [details] Move subimage cache code into separate h/cpp file. View in context: https://bugs.webkit.org/attachment.cgi?id=186934&action=review I think it is misleading to have stuff like subimage(CGImageRef, const FloatRect&) in the new files. The new files should only contain the minimum for the definition and implementation of SubimageCacheWithTimer. I would also promote SubimageCacheWithTimer to a real class with real encapsulation now that it is promoted from a tool to a header. > Source/WebCore/platform/graphics/cg/SubimageCacheWithTimer.cpp:2 > + * Copyright (C) 2013 Apple Inc. All Rights Reserved. You need to preserve the full original copyright too (or hunt who did the changes). > Source/WebCore/platform/graphics/cg/SubimageCacheWithTimer.h:2 > + * Copyright (C) 2013 Apple Inc. All Rights Reserved. Ditto for copyright. Comment on attachment 186934 [details] Move subimage cache code into separate h/cpp file. r- based on Benjamin's reply in Comment #9. We should also remove the image from subimage cache if we are going to release the CGImage. Change the title to reflect that. Created attachment 195802 [details]
remove the image from subimage cache when we releasing the CGImageRef
Comment on attachment 195802 [details] remove the image from subimage cache when we releasing the CGImageRef Clearing flags on attachment: 195802 Committed r147265: <http://trac.webkit.org/changeset/147265> All reviewed patches have been landed. Closing bug. |