Bug 102451

Summary: [CoordGfx] Follow coding style on explicit constructors
Product: WebKit Reporter: Helder Correia <helder.correia>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, noam, webkit.review.bot, zeno
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Helder Correia
Reported 2012-11-15 17:56:08 PST
Use a constructor to do an implicit conversion when the argument is reasonably thought of as a type conversion and the type conversion is fast. Otherwise, use the explicit keyword or a function returning the type. This only applies to single argument constructors.
Attachments
Patch (8.36 KB, patch)
2012-11-15 18:01 PST, Helder Correia 		no flags
DetailsFormatted DiffDiff
Patch (7.90 KB, patch)
2012-11-15 18:24 PST, Helder Correia 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Helder Correia
Comment 1 2012-11-15 18:01:07 PST
Created attachment 174579 [details] Patch
Noam Rosenthal
Comment 2 2012-11-15 18:10:26 PST
Comment on attachment 174579 [details] Patch You don't need to cite the entire style guideline in the changelog...
Helder Correia
Comment 3 2012-11-15 18:24:37 PST
Created attachment 174584 [details] Patch
WebKit Review Bot
Comment 4 2012-11-15 19:50:00 PST
Comment on attachment 174584 [details] Patch Attachment 174584 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14868011 New failing tests: inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html
Noam Rosenthal
Comment 5 2012-11-15 22:48:34 PST
Comment on attachment 174584 [details] Patch Bot failure is a flakyness issue.
WebKit Review Bot
Comment 6 2012-11-16 02:31:45 PST
Comment on attachment 174584 [details] Patch Clearing flags on attachment: 174584 Committed r134919: <http://trac.webkit.org/changeset/134919>
WebKit Review Bot
Comment 7 2012-11-16 02:31:49 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.