Bug 102436

Summary: [BlackBerry] Fix assert in NetworkJob::notifyAuthReceived
Product: WebKit Reporter: Joe Mason <joenotcharles>
Component: Page LoadingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: mifenton, rwlbuis, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
fix
none
fix none

Joe Mason
Reported 2012-11-15 14:46:55 PST
// The scheme might have changed, but the server type shouldn't have! BLACKBERRY_ASSERT(serverType == oldSpace.serverType()); That comment is wrong - the server type could change if we contact a site taking HTTP auth, through an HTTP proxy taking auth of its own. First we get a 407 from the proxy, and then when get passed the proxy, we get a 401 from the end site - so notifyAuthReceived gets called again with auth type Proxy instead of HTTP. The correct thing to do when that happens is skip the "update the auth type in the credentials" step, since these are actually new credentials and not just credentials being reused for a different auth type on the same server.
Attachments
fix (3.58 KB, patch)
2012-11-15 14:51 PST, Joe Mason 		no flags
DetailsFormatted DiffDiff
fix (3.58 KB, patch)
2012-11-15 14:53 PST, Joe Mason 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Joe Mason
Comment 1 2012-11-15 14:51:44 PST
Created attachment 174524 [details] fix
Joe Mason
Comment 2 2012-11-15 14:53:08 PST
Created attachment 174526 [details] fix first pathc had a typo
Rob Buis
Comment 3 2012-11-15 15:24:30 PST
Comment on attachment 174526 [details] fix LGTM.
WebKit Review Bot
Comment 4 2012-11-15 16:24:04 PST
Comment on attachment 174526 [details] fix Clearing flags on attachment: 174526 Committed r134853: <http://trac.webkit.org/changeset/134853>
WebKit Review Bot
Comment 5 2012-11-15 16:24:08 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.