Bug 102433

Summary:

REGRESSION (r134774-r134779): fast/frames/detached-shadow-frame.html failing on Apple Win 7 Release (Tests)

Product:

WebKit

Reporter:

Roger Fong <roger_fong>

Component:

Tools / Tests

Assignee:

Elliott Sprehn <esprehn>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dglazkov, esprehn, ojan, webkit.review.bot

Priority:

Keywords:

LayoutTestFailure, MakingBotsRed, Regression

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

URL:

http://build.webkit.org/results/Apple%20Win%207%20Release%20(Tests)/r134779%20(29956)/results.html

Attachments:

Description	Flags
Patch	none
Patch for landing	none

Roger Fong

Reported 2012-11-15 14:30:19 PST

fast/frames/detached-shadow-frame.html started failing on Apple Win 7 Release (Tests) Suspect Revision: http://trac.webkit.org/changeset/134775 http://build.webkit.org/results/Apple%20Win%207%20Release%20(Tests)/r134774%20(29955)/results.html passed http://build.webkit.org/results/Apple%20Win%207%20Release%20(Tests)/r134779%20(29956)/results.html failed

Attachments
Patch (1.24 KB, patch) 2012-11-15 15:34 PST, Elliott Sprehn	no flags	Details Formatted Diff Diff
Patch for landing (1.28 KB, patch) 2012-11-15 20:23 PST, Elliott Sprehn	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Ojan Vafai

Comment 1 2012-11-15 14:49:46 PST

This is just because this test uses shadow dom and shadow dom isn't enabled for Apple.

Ojan Vafai

Comment 2 2012-11-15 14:49:54 PST

Test just needs to be skipped.

Dimitri Glazkov (Google)

Comment 3 2012-11-15 14:53:59 PST

(In reply to comment #2) > Test just needs to be skipped. .. or use http://trac.webkit.org/browser/trunk/LayoutTests/fast/dom/shadow/resources/polyfill.js I missed that in review.

Elliott Sprehn

Comment 4 2012-11-15 15:34:04 PST

Created attachment 174535 [details] Patch

WebKit Review Bot

Comment 5 2012-11-15 16:41:56 PST

Comment on attachment 174535 [details] Patch Rejecting attachment 174535 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: conflict in Source/WebCore/ChangeLog Failed to merge in the changes. Patch failed at 0001 [BlackBerry] Don't assert when notifyAuthReceived is called with a different auth type When you have resolved this problem run "git rebase --continue". If you would prefer to skip this patch, instead run "git rebase --skip". To restore the original branch and stop rebasing run "git rebase --abort". rebase refs/remotes/origin/master: command returned error: 1 Died at Tools/Scripts/update-webkit line 154. Full output: http://queues.webkit.org/results/14857411

Elliott Sprehn

Comment 6 2012-11-15 20:23:50 PST

Created attachment 174599 [details] Patch for landing

WebKit Review Bot

Comment 7 2012-11-15 22:08:39 PST

Comment on attachment 174599 [details] Patch for landing Rejecting attachment 174599 [details] from commit-queue. New failing tests: platform/chromium/virtual/threaded/compositing/webgl/webgl-background-color.html Full output: http://queues.webkit.org/results/14873004

WebKit Review Bot

Comment 8 2012-11-16 03:30:58 PST

Comment on attachment 174599 [details] Patch for landing Clearing flags on attachment: 174599 Committed r134925: <http://trac.webkit.org/changeset/134925>

WebKit Review Bot

Comment 9 2012-11-16 03:31:02 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.