Bug 102386

Summary: [chromium] MediaStream API: Add missing WebRTCPeerConnectionHandlerClient::didAddRemoteDataChannel
Product: WebKit Reporter: Tommy Widenflycht <tommyw>
Component: WebKit APIAssignee: Tommy Widenflycht <tommyw>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, eric.carlson, feature-media-reviews, fishd, hta, jamesr, tkent+wkapi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 56459    
Attachments:
Description Flags
Patch
none
Patch none

Tommy Widenflycht
Reported 2012-11-15 07:07:27 PST
[chromium] MediaStreamAPI: Add missing WebRTCPeerConnectionHandlerClient::didAddRemoteDataChannel
Attachments
Patch (10.56 KB, patch)
2012-11-15 08:35 PST, Tommy Widenflycht 		no flags
DetailsFormatted DiffDiff
Patch (10.86 KB, patch)
2012-11-16 01:51 PST, Tommy Widenflycht 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tommy Widenflycht
Comment 1 2012-11-15 08:35:46 PST
Created attachment 174454 [details] Patch
WebKit Review Bot
Comment 2 2012-11-15 08:39:54 PST
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Adam Barth
Comment 3 2012-11-15 10:38:49 PST
Comment on attachment 174454 [details] Patch ok
WebKit Review Bot
Comment 4 2012-11-15 11:23:24 PST
Comment on attachment 174454 [details] Patch Clearing flags on attachment: 174454 Committed r134805: <http://trac.webkit.org/changeset/134805>
WebKit Review Bot
Comment 5 2012-11-15 11:23:28 PST
All reviewed patches have been landed. Closing bug.
Tommy Widenflycht
Comment 6 2012-11-16 01:26:15 PST
Patch broke chromium build.
Tommy Widenflycht
Comment 7 2012-11-16 01:51:59 PST
Created attachment 174632 [details] Patch
Tommy Widenflycht
Comment 8 2012-11-16 01:52:22 PST
This patch just differs from the previous one in that the new method in WebRTCPeerConnectionHandlerClient now has an default implementation instead of being pure virtual.
WebKit Review Bot
Comment 9 2012-11-16 10:40:04 PST
Comment on attachment 174632 [details] Patch Clearing flags on attachment: 174632 Committed r134970: <http://trac.webkit.org/changeset/134970>
WebKit Review Bot
Comment 10 2012-11-16 10:40:07 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.