Summary: | [CSS Regions] Absolutely positioned regions do not expand to fill their container | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mihai Balan <mibalan> | ||||||||||
Component: | CSS | Assignee: | Mihnea Ovidenie <mihnea> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | donggwan.kim, eric, gyuyoung.kim, jchaffraix, mihnea, ojan, rakuco, WebkitBugTracker, webkit.review.bot | ||||||||||
Priority: | P2 | Keywords: | AdobeTracked | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Bug Depends on: | |||||||||||||
Bug Blocks: | 57312 | ||||||||||||
Attachments: |
|
Created attachment 175851 [details]
Patch
Comment on attachment 175851 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=175851&action=review > LayoutTests/ChangeLog:3 > + [CSS Regions] Absolutely positioned region does not expand to fill its container Nit: The name sounds weird to me (non-native English speaker though), either missing a leading "An" or a generic plural (Absolutely positioned regions do not ...). Also the name could be improved: you are fixing the case where you have set your logical height and we wouldn't be expanding in the logical width. > LayoutTests/fast/regions/autosize-abspos-anchoredregion.html:6 > + .region { -webkit-flow-from: flow; position: absolute; top: 0px; left: 0px; right: 0px; bottom: 0px; background-color: green; } You are over-constraining your region in most cases below as you have top & bottom, left & right set at the same time, which forces the size of your element. > LayoutTests/fast/regions/autosize-abspos-anchoredregion.html:19 > + </style> A good addition would be a vertical writing-mode test for that too. Created attachment 176194 [details]
Patch for landing
Comment on attachment 176194 [details] Patch for landing Rejecting attachment 176194 [details] from commit-queue. New failing tests: inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html Full output: http://queues.webkit.org/results/14982976 Created attachment 176233 [details]
Patch for landing
(In reply to comment #4) > (From update of attachment 176194 [details]) > Rejecting attachment 176194 [details] from commit-queue. > > New failing tests: > inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html > Full output: http://queues.webkit.org/results/14982976 Unrelated, trying again. Comment on attachment 176233 [details] Patch for landing Clearing flags on attachment: 176233 Committed r135851: <http://trac.webkit.org/changeset/135851> All reviewed patches have been landed. Closing bug. |
Created attachment 174428 [details] HTML file highlighting the problem When a region is absolutely positioned (position: absolute) and sized by specifying all four of top, left, bottom, right it should size to the size of its containing block. Instead, it "collapses" to a zero-height region.