Bug 102372

Summary: [WK2][UNIX] Remove needless comparison in PluginProcessProxy::scanPlugin()
Product: WebKit Reporter: KwangYong Choi <ky0.choi>
Component: Plug-insAssignee: KwangYong Choi <ky0.choi>
Status: RESOLVED INVALID    
Severity: Normal CC: cdumez, gyuyoung.kim
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

KwangYong Choi
Reported 2012-11-15 04:45:34 PST
1. It will generate crash if stdOut is NULL. 2. g_spawn_sync always pass created buffer when it returns true.
Attachments
Patch (1.49 KB, patch)
2012-11-15 04:56 PST, KwangYong Choi 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
KwangYong Choi
Comment 1 2012-11-15 04:56:00 PST
Created attachment 174407 [details] Patch
Chris Dumez
Comment 2 2012-11-15 06:14:00 PST
(In reply to comment #0) > 1. It will generate crash if stdOut is NULL. No it will NOT. It is perfectly safe to pass NULL to free().
KwangYong Choi
Comment 3 2012-11-15 06:16:30 PST
(In reply to comment #2) > (In reply to comment #0) > > 1. It will generate crash if stdOut is NULL. > > No it will NOT. It is perfectly safe to pass NULL to free(). Oh, you're right. I think wrong. I will close this bug.
Chris Dumez
Comment 4 2012-11-15 06:19:55 PST
Please clear review flag as well or it stays in the review queue (even if marked as INVALID).
Note You need to log in before you can comment on or make changes to this bug.