| Summary: | [chromium] WebGL texImage2D fails with deferred image decoding | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Hin-Chung Lam <hclam> | ||||||
| Component: | WebGL | Assignee: | Hin-Chung Lam <hclam> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | dino, jamesr, kbr, nick, senorblanco, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Hin-Chung Lam
2012-11-14 17:59:25 PST
Created attachment 174307 [details]
Patch
Comment on attachment 174307 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=174307&action=review > LayoutTests/fast/images/webgl-teximage2d.html:1 > +<script src="../js/resources/js-test-pre.js"></script> add a <!DOCTYPE html> before this > LayoutTests/fast/images/webgl-teximage2d.html:2 > +<script src="../canvas/webgl/resources/webgl-test.js"></script> why isn't this test in fast/canvas/webgl ? Seems fairly reasonable to me, but I think Ken or Stephen are more familiar with this bit. I talked to Dirk about this. Since I want to run this test with --enable-deferred-image-decoding virtual suite there's a couple options: 1. Add a virtual suite that runs *one* test in fast/canvas/webgl 2. Copy the test from fast/canvas/webgl 3. Write a simple webgl test in fast/images that does exactly what I need I did just 3. Comment on attachment 174307 [details]
Patch
Looks good. Please make sure the WebGL conformance suite and the fast/canvas/webgl/ layout tests pass with --enable-deferred-image-decoding, as there are many other tests which already exercise this path, some potentially more strenuously. r=me
Comment on attachment 174307 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=174307&action=review I have no comments; will leave for Ken. > Source/WebCore/ChangeLog:10 > + generates an ImageFrame marked as incompelte, which WebGL rejects. This results incompelte -> incomplete Note: please mark the patch cq? (Details link) if you would like it submitted to the commit queue. (In reply to comment #7) > Note: please mark the patch cq? (Details link) if you would like it submitted to the commit queue. Thanks. I'll land this manually. Created attachment 174486 [details]
Patch for landing
Comment on attachment 174486 [details] Patch for landing Clearing flags on attachment: 174486 Committed r134816: <http://trac.webkit.org/changeset/134816> All reviewed patches have been landed. Closing bug. |