Layout Test platform/chromium/virtual/deferred/fast/images/exif-orientation.html is failing

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Dimitri Glazkov (Google)]

The following layout test is failing on all platforms.

platform/chromium/virtual/deferred/fast/images/exif-orientation.html

Probable cause:

http://src.chromium.org/viewvc/chrome?view=rev&revision=167750

[Dana Jansens]

I am seeing the exact same result locally with a debug DRT before my large chromium-side change, with WebKit DEPS at that time, vs trunk for chromium and WebKit.

[Dimitri Glazkov (Google)]

Also platform/chromium/virtual/deferred/fast/images/gray-scale-jpeg-with-color-profile.html and platform/chromium/virtual/deferred/fast/images/exif-orientation-css.html

[Dana Jansens]

The scrollbar thumb is gone on mac? Are you seeing that in any other tests?

[Dimitri Glazkov (Google)]

(In reply to comment #3)
> The scrollbar thumb is gone on mac? Are you seeing that in any other tests?

No. This stuff only started happening on virtual/deferred.

[Dana Jansens]

Hey check this out.

-void Settings::setPerTilePaintingEnabled(bool enabled)
-{
-    if (!s_settingsInitialized)
-        reset();
-    s_partialSwapEnabled = enabled;   <---------------- partialSwap!
-}

Seems like per-tile was never on for those tests. Now it is, and they are broken because per-tile is broken.

Should we turn off per-tile for the test suite?

[Dana Jansens]

Well.. It is my opinion that we should rebaseline the linux result, it seems harmless.

And we can rebaseline, or mark as failing, the mac 10.6 ones, with a bug that the scrollbar thumbs disappear with per-tile painting.

[Dana Jansens]

I have filed bugs

For EXIF orientation being broken on Mac with per-tile: http://code.google.com/p/chromium/issues/detail?id=161164

For missing scrollbar thumbs on Mac 10.6 with per-tile: http://code.google.com/p/chromium/issues/detail?id=161167&thanks=161167&ts=1352941830

I think what's left to do for this bug here is to decide to rebaseline or mark as failing these tests.

Rebaseline Linux, Mark as failing Mac? What do you think James?

[James Robinson]

(In reply to comment #7)
> I have filed bugs
> 
> For EXIF orientation being broken on Mac with per-tile: http://code.google.com/p/chromium/issues/detail?id=161164
> 
> For missing scrollbar thumbs on Mac 10.6 with per-tile: http://code.google.com/p/chromium/issues/detail?id=161167&thanks=161167&ts=1352941830
> 
> I think what's left to do for this bug here is to decide to rebaseline or mark as failing these tests.
> 
> Rebaseline Linux, Mark as failing Mac? What do you think James?

That sounds right.

[Dana Jansens]

Committed r135961: <http://trac.webkit.org/changeset/135961>