Bug 102293 – IndexedDB: SerializedScriptValue::toWireString() fails for odd-length serialized data

• Component: New Bugs
• Status: RESOLVED DUPLICATE

[Michael Pruett]

SerializedScriptValue fails to produce a wire string representation value which can be deserialized for odd-length serialized data. The problem is that CloneDeserializer::toWireString() divides value.size() by sizeof(UChar) which omits the final byte of an odd-length buffer producing a wire representation which cannot be deserialized. Appending a zero-valued byte to an odd-length string is one way to fix this problem.

The V8 implementation of SerializedScriptValue avoids this problem by using String as its internal representation and rounding up to an even number of bytes in Writer::ensureSpace(), thus ensuring that the internal representation is always an even number of bytes.

[Michael Pruett]

Created attachment 174271 [details]
Fix SerializedScriptValue::toWireString() for odd-length serialized data

[Joshua Bell]

This is effectively a duplicate of webkit.org/b/99310 - it would make more sense to upload the patch there - but review the discussion first.

The "right" solution is probably to rip the notion of "WireString" out of SSV and use e.g. Vector<char> instead.

*** This bug has been marked as a duplicate of bug 99310 ***