Bug 102273

Summary:

Make old-run-webkit-tests handle setting the results directory properly.

Product:

WebKit

Reporter:

Roger Fong <roger_fong>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

lforschler, roger_fong, slewis

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	thorton: review+

Roger Fong

Reported 2012-11-14 13:01:32 PST

A call to chdirWebkit in old-run-webkit-tests set the current working directory to the OpenSource folder. Thus setting --results-directory to OpenSource/layout-test-results would create OpenSource/layout-test-results inside the main OpenSource folder. This caused many other problems including failure to upload test results and failed future test runs. The solution is to save the current working directory before calling chdirWebKit and then reconstructing the full path to the results directory using the saved directory when setting $testResultsDirectory.

Attachments
patch (2.16 KB, patch) 2012-11-14 16:38 PST, Roger Fong	thorton: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Roger Fong

Comment 1 2012-11-14 13:02:05 PST

<rdar://problem/11571607>

Roger Fong

Comment 2 2012-11-14 16:38:34 PST

Created attachment 174283 [details] patch

Note You need to log in before you can comment on or make changes to this bug.