Bug 102254

Summary: [chromium] Don't let shift-click turn popup into tab.
Product: WebKit Reporter: Eric U. <ericu>
Component: New BugsAssignee: Eric U. <ericu>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch abarth: review+

Eric U.
Reported 2012-11-14 11:12:28 PST
[chromium] Don't let shift-click turn popup into tab.
Attachments
Patch (2.00 KB, patch)
2012-11-14 11:18 PST, Eric U. 		abarth: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric U.
Comment 1 2012-11-14 11:18:40 PST
Created attachment 174207 [details] Patch
Adam Barth
Comment 2 2012-11-14 11:35:50 PST
Comment on attachment 174207 [details] Patch Interesting. Can we add a test for this change? (Perhaps a unit test?)
Eric U.
Comment 3 2012-11-14 12:43:30 PST
Sure, I can put together a unit test for ChromeClientImpl::getNavigationPolicy without pulling in too much else. I'll start a new bug for that.
Eric U.
Comment 4 2012-11-14 12:53:39 PST
Committed r134654: <http://trac.webkit.org/changeset/134654>
Note You need to log in before you can comment on or make changes to this bug.