Bug 102249 – Fix compiler warnings about signed/unsigned comparison on i386

• Component: JavaScriptCore
• Status: RESOLVED FIXED

[Thiago Marcos P. Santos]

Breaks ports building with -Werror.

[Thiago Marcos P. Santos]

Created attachment 174197 [details]
Patch

[Thiago Marcos P. Santos]

Created attachment 174199 [details]
Patch

Fixed ChangeLog.

[Mark Lam]

Comment on attachment 174199 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=174199&action=review

> Source/JavaScriptCore/ChangeLog:8
> +        Add casting to unsigned to shut gcc warnings. Build was broken on

"shut" ==> "shut up" or "quiet down"

> Source/JavaScriptCore/ChangeLog:9
> +        ports compiling with -Werror.

It's not applicable to every port.  So, "ports" ==> "JSVALUE32_64 ports".

> Source/JavaScriptCore/llint/LLIntData.cpp:94
> +    ASSERT(JSValue::LowestTag == static_cast<unsigned> -7);

Conceptually, this is good.  But I'm not sure of the style.  Elsewhere in the code, I either see examples like "unsigned(-7)" or "static_cast<unsigned>(-7)".  I'd be more comfortable if you changed this to use one of those syntax.

[kov's GTK+ EWS bot]

Comment on attachment 174199 [details]
Patch

Attachment 174199 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/14833398

[Thiago Marcos P. Santos]

Created attachment 174238 [details]
Patch

[Mark Lam]

LGTM, but need someone else to r+ cq+.

[WebKit Review Bot]

Comment on attachment 174238 [details]
Patch

Clearing flags on attachment: 174238

Committed r134763: <http://trac.webkit.org/changeset/134763>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.