Bug 102214 – Relocate the ARM NEON SVG filter optimizations

• Component: SVG
• Status: RESOLVED FIXED

[Gabor Rapcsanyi]

Relocate the ARM NEON SVG filter optimizations to WebCore/platform/graphics/cpu/arm/filters.
We should keep all graphics optimizations for ARM here.

[Gabor Rapcsanyi]

Created attachment 174142 [details]
proposed patch

[WebKit Review Bot]

Attachment 174142 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/W..." exit_code: 1
Source/WebCore/platform/graphics/cpu/arm/filters/FELightingNEON.h:27:  #ifndef header guard has wrong style, please use: FELightingNEON_h  [build/header_guard] [5]
Source/WebCore/platform/graphics/cpu/arm/filters/FEGaussianBlurNEON.h:38:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Source/WebCore/platform/graphics/cpu/arm/filters/FEBlendNEON.h:49:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Source/WebCore/platform/graphics/cpu/arm/filters/FEBlendNEON.h:58:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/platform/graphics/cpu/arm/filters/FEBlendNEON.h:69:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Source/WebCore/platform/graphics/cpu/arm/filters/FEBlendNEON.h:78:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Source/WebCore/platform/graphics/cpu/arm/filters/FEBlendNEON.h:94:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/platform/graphics/cpu/arm/filters/FEBlendNEON.h:111:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Total errors found: 8 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Zoltan Herczeg]

Comment on attachment 174142 [details]
proposed patch

r=me, just a few comments

This should be fixed:
#ifndef header guard has wrong style, please use: FELightingNEON_h

View in context: https://bugs.webkit.org/attachment.cgi?id=174142&action=review

> Source/WebCore/ChangeLog:10
> +        From now all graphics optimization for ARM NEON should be go here.

should go

[Gabor Rapcsanyi]

(In reply to comment #3)
> (From update of attachment 174142 [details])
> r=me, just a few comments
> 
> This should be fixed:
> #ifndef header guard has wrong style, please use: FELightingNEON_h
> 
> View in context: https://bugs.webkit.org/attachment.cgi?id=174142&action=review
> 
> > Source/WebCore/ChangeLog:10
> > +        From now all graphics optimization for ARM NEON should be go here.
> 
> should go

Thanks!

Corrected patch landed: http://trac.webkit.org/changeset/134767

[Roger Fong]

Broke all the Windows builds.
Renamed files need to be updated in their respected vcproj files as well.
I can fix it in a bit, unless you want to.

[Gabor Rapcsanyi]

(In reply to comment #5)
> Broke all the Windows builds.
> Renamed files need to be updated in their respected vcproj files as well.
> I can fix it in a bit, unless you want to.

Sorry the ews didn't complain and I forgot about the vcproj files. I will fix it in this bug: https://bugs.webkit.org/show_bug.cgi?id=102469