| Summary: | Some <foo>p -> <foo>q fixes in LLInt64 | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yuqiang Xian <yuqiang.xian> | ||||||||
| Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> | ||||||||
| Status: | NEW --- | ||||||||||
| Severity: | Normal | CC: | barraclough, darin, fpizlo, ggaren, mark.lam, oliver, ossy | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Yuqiang Xian
2012-11-14 01:21:04 PST
Created attachment 174104 [details]
patch
Created attachment 181265 [details]
Rebased patch
Created attachment 194973 [details]
Rebased again
Comment on attachment 194973 [details]
Rebased again
Is there a reason for these changes? I like changing the raw loads to using load*FromInstruction, but I'm not clear on the seemingly random changes from *p to *q.
(In reply to comment #4) > (From update of attachment 194973 [details]) > Is there a reason for these changes? I like changing the raw loads to using load*FromInstruction, but I'm not clear on the seemingly random changes from *p to *q. The motivation is explained in bug #100321. We want to distinguish the "pointer" operations from the "64-bit value" operations. This patch just wants to make sure we consistently obey the rule of using *p for pointers and *q for 64-bit values. If you think this is reasonable, I can make the patch updated with latest code. Thanks. I think that Filip or someone else who knows the assembly issues should review+/cq+ this patch. I’d love to do it but I’m not 100% sure. Could someon review- or review+ this patch? Comment on attachment 194973 [details]
Rebased again
r=me
|