Bug 102117

Summary: [V8] instantiateV8Object should encapulate the tricky creationContext logic
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: dcarney, eric, haraken, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Now with run-bindings-test results none

Adam Barth
Reported 2012-11-13 12:02:59 PST
[V8] instantiateV8Object should encapulate the tricky creationContext logic
Attachments
Patch (5.49 KB, patch)
2012-11-13 12:07 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (22.49 KB, patch)
2012-11-13 12:15 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
Now with run-bindings-test results (23.58 KB, patch)
2012-11-13 12:17 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2012-11-13 12:07:08 PST
Created attachment 173946 [details] Patch
Adam Barth
Comment 2 2012-11-13 12:07:31 PST
I'll land the run-bindings-tests results separately.
Adam Barth
Comment 3 2012-11-13 12:15:48 PST
Created attachment 173952 [details] Patch
Adam Barth
Comment 4 2012-11-13 12:17:18 PST
Created attachment 173953 [details] Now with run-bindings-test results
Eric Seidel (no email)
Comment 5 2012-11-13 12:42:07 PST
Comment on attachment 173953 [details] Now with run-bindings-test results Much better.
WebKit Review Bot
Comment 6 2012-11-13 14:39:00 PST
Comment on attachment 173953 [details] Now with run-bindings-test results Clearing flags on attachment: 173953 Committed r134489: <http://trac.webkit.org/changeset/134489>
WebKit Review Bot
Comment 7 2012-11-13 14:39:04 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.