Summary: | Rename NATIVE_TYPE_ERR to TypeError | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joshua Bell <jsbell> | ||||||||
Component: | New Bugs | Assignee: | Joshua Bell <jsbell> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | abarth, arv, darin, eric.carlson, feature-media-reviews, haraken, japhet, ojan, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | 91679 | ||||||||||
Bug Blocks: | |||||||||||
Attachments: |
|
Description
Joshua Bell
2012-11-13 11:54:23 PST
Created attachment 173945 [details]
Patch
Comment on attachment 173945 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173945&action=review > Source/WebCore/bindings/v8/V8ThrowException.h:32 > +enum V8ErrorType { Prefixing "ErrorType" itself is not strictly necessary, but there seems to be precedent for prefix consistency between enum and members. > Source/WebCore/dom/Element.cpp:-1523 > - ec = NATIVE_TYPE_ERR; These need to be switched to TYPE_MISMATCH_ERR in another patch. Uploading here for now to exercise build bots. > Source/WebCore/dom/Element.cpp:-1565 > - ec = NATIVE_TYPE_ERR; Ditto. > Source/WebCore/dom/ExceptionCode.h:68 > + // WebIDL exception types, handled by the binding layer. I don't know if we should add all of these now given that they're unused/untested. But I wanted to see if the build bots are happy with these names. Comment on attachment 173945 [details]
Patch
LGTM... I would r+ if I was a reviewere
Created attachment 173974 [details]
Patch
Comment on attachment 173974 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173974&action=review > Source/WebCore/ChangeLog:9 > + V8 binding code had colliding enum members, which required prefixing. For consistency I want to make the same change for JSC too. SyntaxError -> jsSyntaxError Comment on attachment 173974 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173974&action=review >> Source/WebCore/ChangeLog:9 >> + V8 binding code had colliding enum members, which required prefixing. > > For consistency I want to make the same change for JSC too. SyntaxError -> jsSyntaxError I didn't find a similar enum in the JSC code. Can you point me at what would need updating? (In reply to comment #6) > I didn't find a similar enum in the JSC code. Can you point me at what would need updating? Ah, JSC uses createSyntaxError() etc instead of enums. Sorry, ignore my comment. Comment on attachment 173974 [details]
Patch
Thanks. Going ahead with claiming WebCore::GeneralError, WebCore::RangeError etc. in the ExceptionCode enum, even though the types aren't handled by binding code yet.
Comment on attachment 173974 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173974&action=review > Source/WebCore/dom/ExceptionCode.h:75 > + GeneralError = 100, > + EvalError = 101, > + RangeError = 102, > + ReferenceError = 103, > + SyntaxError = 104, > + TypeError = 105, > + URIError = 106, I agree that we might want to add these some day, but it seems a little dangerous to add them all now when they are not implemented in the bindings. Created attachment 174215 [details]
Patch for landing
Comment on attachment 174215 [details] Patch for landing Clearing flags on attachment: 174215 Committed r134646: <http://trac.webkit.org/changeset/134646> All reviewed patches have been landed. Closing bug. |