Bug 102113
Summary: | [EFL] Wrong scaling/layout width on many web sites. | ||
---|---|---|---|
Product: | WebKit | Reporter: | Yael <yael> |
Component: | WebKit EFL | Assignee: | Nobody <webkit-unassigned> |
Status: | RESOLVED WONTFIX | ||
Severity: | Normal | CC: | dongseong.hwang, kenneth, lucas.de.marchi, mcatanzaro, mikhail.pozdnyakov, tmpsantos |
Priority: | P2 | ||
Version: | 528+ (Nightly build) | ||
Hardware: | Unspecified | ||
OS: | Unspecified |
Yael
After r134142 layout of many websites is incorrect in EFL's MiniBrowser.
r134375 fixed some, but not all of the issues.
Some sites where the regression is obvious (check the top toolbar):
http://www.google.com/imghp?hl=en&tab=wi
https://play.google.com/store?hl=en&tab=i8
Attachments | ||
---|---|---|
Add attachment proposed patch, testcase, etc. |
Dongseong Hwang
I'm sorry for this regression.
Could you check that Bug 101918 fixed the EFL bug? Thanks in advance.
Yael
(In reply to comment #1)
> I'm sorry for this regression.
>
> Could you check that Bug 101918 fixed the EFL bug? Thanks in advance.
Only partially. Without 101918, all the content was streched on the screen, now it is better, but still broken.
Yael
Updating the title. It seems that this issue can be seen even in earlier revisions. Sorry for making the wrong assumption here.
Dongseong Hwang
(In reply to comment #3)
> Updating the title. It seems that this issue can be seen even in earlier revisions. Sorry for making the wrong assumption here.
Thanks for checking!
Could you explain how we see the bug. I want to check WebKit Qt also.
Yael
It seems that http://trac.webkit.org/changeset/133761 caused some of the regression. e.g. in google image search the bottom bar is misplaced, but removing the setting from r133761 fixes the issue. Also the height of the top black bar is wrong in that page. The height is fixed by removing the setting.
Other broken sites:
1. The top bar in google play should cover the whole width, but it doesn't.
2. http://www.npr.org/blogs/thetwo-way/2012/11/14/165130117/live-blog-president-obamas-news-conference has some fixed elements. When loading the page in MiniBrowser (EFL and Qt) you see a fixed layer at the bottom, but it should not be there, it should be to the left.
Yael
Also r133807 exposed a bug that we are not calculating fixed layer bounds correctly, so after r133807, they don't get their own graphics layer.
Yael
(In reply to comment #6)
> Also r133807 exposed a bug that we are not calculating fixed layer bounds correctly, so after r133807, they don't get their own graphics layer.
Both in Qt and EFL.
Dongseong Hwang
(In reply to comment #7)
> (In reply to comment #6)
> Both in Qt and EFL.
This seems to be a problem of Coordinated Graphics, not TexMap.
In Qt WebKit1, rendering both sites is similar to chrome browser.
This problem looks like tricky. I can not sure this problem is bug or not. I suspect TBS causing this difference.
Kenneth Rohde Christiansen
(In reply to comment #8)
> (In reply to comment #7)
> > (In reply to comment #6)
> > Both in Qt and EFL.
>
> This seems to be a problem of Coordinated Graphics, not TexMap.
> In Qt WebKit1, rendering both sites is similar to chrome browser.
> This problem looks like tricky. I can not sure this problem is bug or not. I suspect TBS causing this difference.
So it is simple, we now layout using fixed layout given the viewport width in the case no viewport is set by the page. But many pages do, so it must be related to this
Yael
(In reply to comment #9)
> (In reply to comment #8)
> > (In reply to comment #7)
> > > (In reply to comment #6)
> > > Both in Qt and EFL.
> >
> > This seems to be a problem of Coordinated Graphics, not TexMap.
> > In Qt WebKit1, rendering both sites is similar to chrome browser.
> > This problem looks like tricky. I can not sure this problem is bug or not. I suspect TBS causing this difference.
>
> So it is simple, we now layout using fixed layout given the viewport width in the case no viewport is set by the page. But many pages do, so it must be related to this
google image search sets min-width=980 and google play sets min-width=1026. That does not work well with FixedLayout that is smaller than the min-width set by the site.
Michael Catanzaro
Closing this bug because the EFL port has been removed from trunk.
If you feel this bug applies to a different upstream WebKit port and was closed in error, please either update the title and reopen the bug, or leave a comment to request this.