Bug 102070 – Some Perf tests fail due to output text parse error

• Component: Tools / Tests
• Status: NEW

[Pravin D]

Created attachment 173864 [details]
Failing Testcase

Description : When some perf tests run using ./Tools/Scripts/run-perf-tests , fail with the following msg
$./Tools/Scripts/run-perf-tests PerformanceTests/reattach/abs_to_static_inline_inline.html
Running 1 tests
Running reattach/abs_to_static_inline_inline.html (1 of 1)
 Running 20 times
FAILED
Finished: 47.007584 s

Even though the test has run successfully, the result is not published to PerformanceTestsResults.json due to the above failure.

The reason is that is some cases the output.text in being parsed in parse_output() in Tools/Scripts/webkitpy/perftest.py contains a leading space.

parse_output() calls _should_ignore_line_in_parser_test_result() which in turn uses a list "_lines_to_ignore_in_parser_result" to check if the line has to ignored or not. 
As _lines_to_ignore_in_parser_result does not expect a line with leading/trailing spaces , _should_ignore_line_in_parser_test_result() fails which results in the parse_output() assuming
that an error has occured.

Attaching the perf test.

[Pravin D]

Created attachment 173872 [details]
Patch

[Adam Barth]

Looks like a patch for rniwa.

[Ryosuke Niwa]

Comment on attachment 173872 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=173872&action=review

> Tools/Scripts/webkitpy/performance_tests/perftest.py:108
> +        line = line.strip()

No. This is a bug in the test. We need to fix the test.

[Ryosuke Niwa]

The whole point of parser being very strict about the output is so that we can detect incorrectness errors. The test output shouldn’t contain superfluous whitespaces.