Bug 102063

Summary: Porting WebKit to a new graphics library backend
Product: WebKit Reporter: Zhang Ji Peng <onecoolx>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: UNCONFIRMED ---    
Severity: Normal CC: abarth, ap, cmarcelo, eric, gaborb, onecoolx, peter, reed, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: All   
Attachments:
Description Flags
picasso backend porting abarth: review-

Description Zhang Ji Peng 2012-11-13 02:12:44 PST
Created attachment 173852 [details]
picasso backend porting

Porting webkit to a new graphics library for rendering.  I porting webkit to a new graphics library, because I need to rendeting webpage to any platform. The graphic library named Picasso(http://picasso-graphic.googlecode.com/files/picasso12_source.tar.gz). Only a Mobile browser use this port at present(http://www.zncsoft.com/down.html).
Comment 1 WebKit Review Bot 2012-11-13 02:16:47 PST
Attachment 173852 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files']" exit_code: 1
Total errors found: 0 in 0 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 2 Peter Beverloo 2012-11-13 02:52:21 PST
Which port will be using Picasso? Will it be actively maintained?

Please send an e-mail to webkit-dev about your plans so others can chime in here.
Comment 3 Eric Seidel (no email) 2012-11-13 17:00:37 PST
According to http://code.google.com/p/picasso-graphic/ there is only one member of that project (the author of this bug).

Unless there are ports wanting to use this already, I believe this violates one of WebKit's stated non-goals:

WebKit is an engineering project not a science project.
For new features to be adopted into WebKit, we strongly prefer for the technology or at least the use case for it to be proven.

http://www.webkit.org/projects/goals.html
Comment 4 Zhang Ji Peng 2012-11-13 21:13:40 PST
(In reply to comment #3)
> According to http://code.google.com/p/picasso-graphic/ there is only one member of that project (the author of this bug).
> 
> Unless there are ports wanting to use this already, I believe this violates one of WebKit's stated non-goals:
> 
> WebKit is an engineering project not a science project.
> For new features to be adopted into WebKit, we strongly prefer for the technology or at least the use case for it to be proven.
> 
> http://www.webkit.org/projects/goals.html

The Picasso porting is used to a mobile webbrowser. Home page athttp://www.zncsoft.com/down.html  It is running on WinCE, Windows Mobile and Linux. All platforms use the same porting, so I want to contribute to this part of the code.
Comment 5 Adam Barth 2012-11-15 10:51:12 PST
Comment on attachment 173852 [details]
picasso backend porting

I'm sorry, but this patch is too large to review.  We also need buy-in from the community before making a change like this.
Comment 6 Zhang Ji Peng 2012-11-16 09:21:37 PST
(In reply to comment #5)
> (From update of attachment 173852 [details])
> I'm sorry, but this patch is too large to review.  We also need buy-in from the community before making a change like this.
Please tell me the right way to contribute a porting , I will be very grateful.
Comment 7 Adam Barth 2012-11-16 09:46:04 PST
> Please tell me the right way to contribute a porting , I will be very grateful.

The first step is to get community buy-in for this project.  The thread you've started in webkit-dev is a good way to do that.

After you have support from the community, you'll need to break up this patch into smaller pieces that can be reviewed.  I think we recommend patches that are smaller than 20 KB, but that's just a guideline, not any kind of hard rule.

I think the main question that people have about this patch is how widely used will USE(PICASSO) be?  Are you the only one who is going to work on it?  Are there going to be buildbots that build and test this configuration?  etc.  Supporting a new graphics back end is a lot of work for the community.
Comment 8 Zhang Ji Peng 2012-11-17 09:09:44 PST
(In reply to comment #7)
> > Please tell me the right way to contribute a porting , I will be very grateful.
> 
> The first step is to get community buy-in for this project.  The thread you've started in webkit-dev is a good way to do that.
> 
> After you have support from the community, you'll need to break up this patch into smaller pieces that can be reviewed.  I think we recommend patches that are smaller than 20 KB, but that's just a guideline, not any kind of hard rule.
> 
> I think the main question that people have about this patch is how widely used will USE(PICASSO) be?  Are you the only one who is going to work on it?  Are there going to be buildbots that build and test this configuration?  etc.  Supporting a new graphics back end is a lot of work for the community.

ok, I get it. Thanks