Bug 102023 – Web Inspector: [WK2]: Add a dock button to the top right corner of the window

• Component: Web Inspector (Deprecated)
• Status: RESOLVED FIXED

[Timothy Hatcher]

We should add a dock button to the top right corner of the window (similar to the full screen button).

[Timothy Hatcher]

Created attachment 173779 [details]
Proposed Change

[WebKit Review Bot]

Attachment 173779 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Timothy Hatcher]

Created attachment 173780 [details]
Screenshot

[kov's GTK+ EWS bot]

Comment on attachment 173779 [details]
Proposed Change

Attachment 173779 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/14820353

[Anders Carlsson]

Comment on attachment 173779 [details]
Proposed Change

View in context: https://bugs.webkit.org/attachment.cgi?id=173779&action=review

> Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm:140
> +- (NSCursor *)_cursorForResizeDirection:(NSInteger)direction {

Newline before {

> Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm:144
> +    if (direction == 1 && ![_dockButton.get() isHidden])
> +        return nil;

You don't need the .get() here.

[Joseph Pecoraro]

View in context: https://bugs.webkit.org/attachment.cgi?id=173779&action=review

> Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm:199
> +    // Get the frame view, the usperview of the content view, and its frame.

Nit (typo): "usperview" => "superview"

[Timothy Hatcher]

r134346