Bug 102013

Summary: Replace unnecessary ArgumentDecoder member functions with decode overloads
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: abecsi, cmarcelo, menard, noam, ossy, sam, webkit-ews, webkit.review.bot, zeno
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch andersca: review+

Anders Carlsson
Reported 2012-11-12 17:01:47 PST
Replace unnecessary ArgumentDecoder member functions with decode overloads
Attachments
Patch (32.97 KB, patch)
2012-11-12 17:19 PST, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
Patch (28.20 KB, patch)
2013-01-29 18:52 PST, Sam Weinig 		andersca: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2012-11-12 17:19:31 PST
Created attachment 173767 [details] Patch
Early Warning System Bot
Comment 2 2012-11-12 17:32:40 PST
Comment on attachment 173767 [details] Patch Attachment 173767 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/14821342
EFL EWS Bot
Comment 3 2012-11-12 17:43:53 PST
Comment on attachment 173767 [details] Patch Attachment 173767 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/14803950
Build Bot
Comment 4 2012-11-12 18:11:45 PST
Comment on attachment 173767 [details] Patch Attachment 173767 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/14822231
Csaba Osztrogonác
Comment 5 2013-01-15 23:18:26 PST
Comment on attachment 173767 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173767&action=review > Source/WebKit2/Platform/win/SharedMemoryWin.cpp:101 > + if (!decoder->decode(32(sourcePID)) I think you meant decode(size) > Source/WebKit2/Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:205 > + if (!decoder->decode(32(size)) ditto > Source/WebKit2/Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:283 > + if (!decoder->decode(32(parametersSize)) ditto > Source/WebKit2/Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:299 > + if (!decoder->decode(32(arrayParameterSize)) ditto > Source/WebKit2/Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:313 > + if (!decoder->decode(32(numberParameterSize)) ditto > Source/WebKit2/Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:425 > + if (!decoder->decode(32(operationsSize)) ditto > Source/WebKit2/Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:582 > + if (!decoder->decode(32(numberOfSteps)) ditto > Source/WebKit2/Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:666 > + if (!decoder->decode(32(fillMode)) ditto > Source/WebKit2/Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:688 > + if (!decoder->decode(32(keyframesSize)) ditto
Csaba Osztrogonác
Comment 6 2013-01-15 23:19:20 PST
(In reply to comment #5) > (From update of attachment 173767 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=173767&action=review > > > Source/WebKit2/Platform/win/SharedMemoryWin.cpp:101 > > + if (!decoder->decode(32(sourcePID)) > > I think you meant decode(size) decode(size) -> decode(*)
Sam Weinig
Comment 7 2013-01-29 18:52:19 PST
Created attachment 185374 [details] Patch
Sam Weinig
Comment 8 2013-01-29 19:30:50 PST
Committed r141209: <http://trac.webkit.org/changeset/141209>
Note You need to log in before you can comment on or make changes to this bug.