Bug 101967

Summary: [BlackBerry] Ensure we only receive one KeyUp per key event
Product: WebKit Reporter: Nima Ghanavatian <nima.ghanavatian>
Component: WebKit BlackBerryAssignee: Nima Ghanavatian <nima.ghanavatian>
Status: RESOLVED FIXED    
Severity: Normal CC: mifenton, rwlbuis, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Nima Ghanavatian
Reported 2012-11-12 12:38:59 PST
We are creating some synthetic keyUps which cause dual keyUp processing when the original event comes in. Filtering when to create it synthetically and when to allow the original to be processed.
Attachments
Patch (8.25 KB, patch)
2012-11-12 12:48 PST, Nima Ghanavatian 		no flags
DetailsFormatted DiffDiff
Patch (8.24 KB, patch)
2012-11-12 13:31 PST, Nima Ghanavatian 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Nima Ghanavatian
Comment 1 2012-11-12 12:48:45 PST
Created attachment 173694 [details] Patch
Rob Buis
Comment 2 2012-11-12 12:57:47 PST
Comment on attachment 173694 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173694&action=review Looks good in general, some issues to be cleared up. > Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:1589 > + if (m_expectedKeyUpChar == keyboardEvent.character() || (WTF::isASCIIUpper(m_expectedKeyUpChar) && m_expectedKeyUpChar == WTF::toASCIIUpper(keyboardEvent.character()))) { You should not need the WTF:: prefix. > Source/WebKit/blackberry/WebKitSupport/InputHandler.h:241 > + short unsigned int m_expectedKeyUpChar; What type do you want? This does not seem right.
Nima Ghanavatian
Comment 3 2012-11-12 13:31:12 PST
Created attachment 173707 [details] Patch
Rob Buis
Comment 4 2012-11-12 13:33:52 PST
Comment on attachment 173707 [details] Patch LGTM.
WebKit Review Bot
Comment 5 2012-11-12 18:01:39 PST
Comment on attachment 173707 [details] Patch Clearing flags on attachment: 173707 Committed r134333: <http://trac.webkit.org/changeset/134333>
WebKit Review Bot
Comment 6 2012-11-12 18:01:43 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.