Bug 101932

Summary: [V8] Remove LIKELY()/UNLIKELY() from V8 binding cpp files
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: WebCore JavaScriptAssignee: Kentaro Hara <haraken>
Status: RESOLVED WONTFIX    
Severity: Normal CC: abarth, andersca, eric.carlson, feature-media-reviews, japhet, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch haraken: review-

Kentaro Hara
Reported 2012-11-12 05:24:45 PST
It doesn't make sense to have LIKELY()/UNLIKELY() in cpp files.
Attachments
Patch (29.66 KB, patch)
2012-11-12 05:26 PST, Kentaro Hara 		haraken: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2012-11-12 05:26:37 PST
Created attachment 173631 [details] Patch
Adam Barth
Comment 2 2012-11-12 09:44:02 PST
Comment on attachment 173631 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173631&action=review > Source/WebCore/ChangeLog:8 > + It doesn't make sense to have LIKELY()/UNLIKELY() in cpp files. Why not? > Source/WebCore/bindings/v8/DOMDataStore.cpp:58 > - if (UNLIKELY(!!data->domDataStore())) > + if (!!data->domDataStore()) You can get rid of the !! here as well. That was just to make UNLIKELY happy. > Source/WebCore/bindings/v8/DOMDataStore.cpp:61 > - if (UNLIKELY(!!context)) > + if (!!context) ditto > Source/WebCore/bindings/v8/V8Binding.cpp:324 > - if (UNLIKELY(!!(isolatedShell = V8DOMWindowShell::getEntered()))) > + if (!!(isolatedShell = V8DOMWindowShell::getEntered())) here too
Adam Barth
Comment 3 2012-11-12 09:44:31 PST
Have you run any performance tests to verify that these aren't needed?
Kentaro Hara
Comment 4 2012-11-12 17:37:31 PST
Comment on attachment 173631 [details] Patch > Have you run any performance tests to verify that these aren't needed? I should do it. I was just blindly believing that LIKELY/UNLIKELY would be meaningful in a part of inlined functions in headers.
Anders Carlsson
Comment 5 2013-05-02 11:47:21 PDT
V8 is gone from WebKit.
Note You need to log in before you can comment on or make changes to this bug.