Bug 101920 – [EFL][WK2] Add APIs to toggle plug-ins support

• Component: WebKit EFL
• Status: RESOLVED FIXED

[Yuni Jeong]

Add setting APIs for plug-ins and a unit test.

[Yuni Jeong]

Created attachment 173820 [details]
Patch

[WebKit Review Bot]

Comment on attachment 173820 [details]
Patch

Rejecting attachment 173820 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
).
patching file Source/WebKit2/UIProcess/API/efl/ewk_settings.h
Hunk #1 succeeded at 424 with fuzz 2 (offset 56 lines).
patching file Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_settings.cpp
Hunk #1 FAILED at 197.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_settings.cpp.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Gyuyoung K..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue

Full output: http://queues.webkit.org/results/14986989

[Yuni Jeong]

Created attachment 177455 [details]
Patch

[Chris Dumez]

Comment on attachment 177455 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=177455&action=review

Patch looks technically OK but I would improve the documentation a bit.

> Source/WebKit2/ChangeLog:3
> +        [EFL][WK2] Add APIs to get/set plug-ins.

"[EFL][WK2] Add APIs to toggle plug-ins support"

> Source/WebKit2/ChangeLog:8
> +        Add setting APIs for plug-ins and a unit test.

"Add setting APIs to toggle plug-ins support and add corresponding API tests."

> Source/WebKit2/UIProcess/API/efl/ewk_settings.h:428
> + * Enables/disables the plug-ins.

Toggles plug-in support.

> Source/WebKit2/UIProcess/API/efl/ewk_settings.h:430
> + * By default, the plug-ins is enabled.

"By default, plug-ins support is enabled."

> Source/WebKit2/UIProcess/API/efl/ewk_settings.h:432
> + * @param settings settings object to set the plug-ins

"object to set plug-ins support"

> Source/WebKit2/UIProcess/API/efl/ewk_settings.h:433
> + * @param enable @c EINA_TRUE to enable the plug-ins

"to enable plug-ins support"

> Source/WebKit2/UIProcess/API/efl/ewk_settings.h:441
> + * Returns whether the plug-ins is enabled or not.

"Returns whether plug-ins support is enabled or not."

> Source/WebKit2/UIProcess/API/efl/ewk_settings.h:443
> + * @param settings settings object to query whether the plug-ins is enabled

"... whether plug-ins support is enabled"

> Source/WebKit2/UIProcess/API/efl/ewk_settings.h:445
> + * @return @c EINA_TRUE if the plug-ins is enabled

"if plug-ins support is enabled"

[Yuni Jeong]

Created attachment 177464 [details]
Patch

[Yuni Jeong]

As Christophe Dumez's comment,
i changed and reuploaded.

[Chris Dumez]

Comment on attachment 177464 [details]
Patch

LGTM, thanks.

[Jinwoo Song]

Please change the bug title, too.

[Yuni Jeong]

I changed bug title.

[WebKit Review Bot]

Comment on attachment 177464 [details]
Patch

Clearing flags on attachment: 177464

Committed r136504: <http://trac.webkit.org/changeset/136504>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.