Bug 101915

Summary: hitTestResultAtPoint does two hit-tests if called on non main frame
Product: WebKit Reporter: Allan Sandfeld Jensen <allan.jensen>
Component: UI EventsAssignee: Allan Sandfeld Jensen <allan.jensen>
Status: RESOLVED FIXED    
Severity: Normal CC: tonikitoo, webkit.review.bot
Priority: P2    
Version: 420+   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 98139    
Attachments:
Description Flags
Patch none

Allan Sandfeld Jensen
Reported 2012-11-12 03:07:09 PST
EventHandler::hitTestResultAtPoint performs a second hit-test if it hits something and it was not started on the main-frame. Due to another quirk in RenderLayer hit-tests will in most cases pretend to hit the frame. This leads to not only needlessly performing multiple test, but having rare cases where the returned empty result is not performed from the perspective of the main frame. Changing the logic to always redirect to the main-frame will save one of the hit-tests in most cases, and simplify the hitTestResult to always being started in the context of the main-frame. The last part is needed to clarify the hitTestResult interface in bug #98139
Attachments
Patch (3.70 KB, patch)
2012-11-12 03:21 PST, Allan Sandfeld Jensen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Allan Sandfeld Jensen
Comment 1 2012-11-12 03:21:54 PST
Created attachment 173603 [details] Patch
Antonio Gomes
Comment 2 2012-11-12 05:41:39 PST
Comment on attachment 173603 [details] Patch r=me
WebKit Review Bot
Comment 3 2012-11-12 10:13:42 PST
Comment on attachment 173603 [details] Patch Clearing flags on attachment: 173603 Committed r134253: <http://trac.webkit.org/changeset/134253>
WebKit Review Bot
Comment 4 2012-11-12 10:13:45 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.