Bug 101913

Summary: Remove HTMLInputElement dependency from PickerIndicatorElement
Product: WebKit Reporter: Kunihiko Sakamoto <ksakamoto>
Component: FormsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: mifenton, tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 101889    
Attachments:
Description Flags
Patch
none
Patch 2 none

Description Kunihiko Sakamoto 2012-11-12 02:21:43 PST 
Introduce PickerIndicatorOwner interface that replaces the role of hostInput() in PickerIndicatorElement. It makes easier to add interactions between picker indicator and its owner without adding functions to HTMLInputElement.
Comment 1 Kunihiko Sakamoto 2012-11-12 02:42:10 PST 
Created attachment 173596 [details]
Patch
Comment 2 Kent Tamura 2012-11-12 02:54:08 PST 
Comment on attachment 173596 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=173596&action=review

The code looks ok.  One comment.

> Source/WebCore/html/shadow/PickerIndicatorElement.h:53
> +        virtual bool isPickerIndicatorOwnerDisabled() const = 0;
> +        virtual bool isPickerIndicatorOwnerReadOnly() const = 0;

They are called together every time.  So we may merge them into one function like isPickerIndicatorOwnerDisabledOrReadOnly(). This pattern is used in FieldOwner in WebCore/html/shadow/DateTimeFieldElement.h.
Comment 3 Kunihiko Sakamoto 2012-11-12 03:16:21 PST 
Created attachment 173600 [details]
Patch 2
Comment 4 Kunihiko Sakamoto 2012-11-12 03:16:41 PST 
Comment on attachment 173596 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=173596&action=review

>> Source/WebCore/html/shadow/PickerIndicatorElement.h:53
>> +        virtual bool isPickerIndicatorOwnerReadOnly() const = 0;
> 
> They are called together every time.  So we may merge them into one function like isPickerIndicatorOwnerDisabledOrReadOnly(). This pattern is used in FieldOwner in WebCore/html/shadow/DateTimeFieldElement.h.

Done.
Comment 5 Kent Tamura 2012-11-12 03:30:18 PST 
Comment on attachment 173600 [details]
Patch 2

ok, great.
Comment 6 WebKit Review Bot 2012-11-12 04:22:17 PST 
Comment on attachment 173600 [details]
Patch 2

Clearing flags on attachment: 173600

Committed r134206: <http://trac.webkit.org/changeset/134206>
Comment 7 WebKit Review Bot 2012-11-12 04:22:20 PST 
All reviewed patches have been landed.  Closing bug.