Bug 101905

Summary:

Web Inspector: use last selection as complementary signal when applying DOM changes to the text model.

Product:

WebKit

Reporter:

Pavel Feldman <pfeldman>

Component:

Web Inspector (Deprecated)

Assignee:

Pavel Feldman <pfeldman>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
[Patch] Straw man, not for landing	none
Patch	none
Patch	none
Patch	none

Pavel Feldman

Reported 2012-11-11 23:55:39 PST

Currently we use heuristics for detecting damaged model range upon DOM mutation. This change adds signals from the last selection and keyboard events in order to further improve the heuristics quality.

Attachments
[Patch] Straw man, not for landing (8.99 KB, patch) 2012-11-12 00:02 PST, Pavel Feldman	no flags	Details Formatted Diff Diff
Patch (13.20 KB, patch) 2012-11-13 10:25 PST, Pavel Feldman	no flags	Details Formatted Diff Diff
Patch (13.19 KB, patch) 2012-11-13 10:28 PST, Pavel Feldman	no flags	Details Formatted Diff Diff
Patch (15.13 KB, patch) 2012-11-14 01:58 PST, Pavel Feldman	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Pavel Feldman

Comment 1 2012-11-12 00:02:44 PST

Created attachment 173575 [details] [Patch] Straw man, not for landing

Pavel Feldman

Comment 2 2012-11-13 10:25:10 PST

Created attachment 173920 [details] Patch

Pavel Feldman

Comment 3 2012-11-13 10:28:35 PST

Created attachment 173921 [details] Patch

Vsevolod Vlasov

Comment 4 2012-11-14 01:33:29 PST

Comment on attachment 173921 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173921&action=review > Source/WebCore/inspector/front-end/DefaultTextEditor.js:473 > + return this._mainPanel._lastSelection; There are still some _lastSelection usages in editor, r- for that. > Source/WebCore/inspector/front-end/DefaultTextEditor.js:2153 > + var isBackspace = this._keyDownCode === WebInspector.KeyboardShortcut.Keys.Backspace.code; Delete? > Source/WebCore/inspector/front-end/DefaultTextEditor.js:2165 > + var range = this._lastSelection.clone(); backwards selection?

Pavel Feldman

Comment 5 2012-11-14 01:58:52 PST

Created attachment 174114 [details] Patch

Vsevolod Vlasov

Comment 6 2012-11-14 02:26:56 PST

Comment on attachment 174114 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=174114&action=review > Source/WebCore/inspector/front-end/DefaultTextEditor.js:2192 > + {console.log(1); please remove

Pavel Feldman

Comment 7 2012-11-14 03:33:26 PST

Committed r134591: <http://trac.webkit.org/changeset/134591>

Vsevolod Vlasov

Comment 8 2012-11-14 05:09:04 PST

Vsevolod Vlasov

Comment 9 2012-11-14 05:09:21 PST

Comment on attachment 174114 [details] Patch oops

Note You need to log in before you can comment on or make changes to this bug.