Summary: | NetworkProcess: Use an accurate shouldContentSniff value when creating ResourceHandles | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brady Eidson <beidson> | ||||||||
Component: | WebKit2 | Assignee: | Brady Eidson <beidson> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | ap, japhet, sam, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Mac | ||||||||||
OS: | All | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 98537 | ||||||||||
Attachments: |
|
Description
Brady Eidson
2012-11-11 16:09:28 PST
Created attachment 173526 [details]
Patch v1
This patch should work nicely.
We might have to rethink the RemoteNetworkingContext messaging if it becomes problematic.
Attachment 173526 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebKit2/NetworkProcess/mac/RemoteNetworkingContext.h:44: The parameter name "connection" adds no information, so it should be removed. [readability/parameter_name] [5]
Total errors found: 1 in 17 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 173526 [details]
Patch v1
r- since I don't think the RemoteNetworkingContext needs a connection pointer.
Created attachment 173528 [details]
Patch v2
Alexey and I discussed the RemoteNetworkingContext change in person. Repurposing this bug to be just about content sniffing. Created attachment 173696 [details]
Patch v3 - Just content sniffing
Comment on attachment 173696 [details] Patch v3 - Just content sniffing View in context: https://bugs.webkit.org/attachment.cgi?id=173696&action=review > Source/WebKit2/NetworkProcess/NetworkResourceLoadScheduler.h:29 > +#include <WebCore/ResourceLoaderOptions.h> I'm not sure if it's correct to use ResourceLoaderOptions in network process. There is no ResourceLoader here. (In reply to comment #7) > (From update of attachment 173696 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=173696&action=review > > > Source/WebKit2/NetworkProcess/NetworkResourceLoadScheduler.h:29 > > +#include <WebCore/ResourceLoaderOptions.h> > > I'm not sure if it's correct to use ResourceLoaderOptions in network process. There is no ResourceLoader here. I think "ResourceLoaderOptions" is a misnomer for the file, and perhaps it should be called "ResourceLoadingOptions" That's the brave new world we're charting. |