Bug 101851 – Including <CoreText/CoreText.h> breaks the chromium/mac build.

• Component: New Bugs
• Status: RESOLVED FIXED

[WebKit Review Bot]

http://trac.webkit.org/changeset/134146 broke the build:
Including <CoreText/CoreText.h> breaks the chromium/mac build. (Requested by mkwst on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear

[WebKit Review Bot]

Created attachment 173476 [details]
ROLLOUT of r134146

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.

Comment on attachment 173476 [details]
ROLLOUT of r134146

Please post a sensible patch, such as one reverting only the #include directive.

[Mike West]

Hi! I did look for you on #webkit before requesting the rollout, and chromium/mac hasn't built in the last ~20 hours. I don't think rolling the patch out would have been unreasonable.

(In reply to comment #2)
> (From update of attachment 173476 [details])
> Please post a sensible patch, such as one reverting only the #include directive.

If I knew what I was doing in this area of the code, I would have. :) I got a pointer on the channel in a direction that looks good, though. If it ends up working, I'll post a patch here.

[Mike West]

Created attachment 173478 [details]
Patch

[Mike West]

(In reply to comment #4)
> Created an attachment (id=173478) [details]
> Patch

This compiles locally, but it's copy/paste cargo-culting. Hopefully it's also correct. :)

Comment on attachment 173478 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=173478&action=review

> Source/WebCore/platform/graphics/mac/SimpleFontDataCoreText.cpp:34
> +#if PLATFORM(WX) || PLATFORM(CHROMIUM)
> +#include <ApplicationServices/ApplicationServices.h>
> +#else
>  #include <CoreText/CoreText.h>
> +#endif

This is not necessary. ApplicationServices.h can be used everywhere.

[Mike West]

(In reply to comment #6)
> (From update of attachment 173478 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=173478&action=review
> 
> > Source/WebCore/platform/graphics/mac/SimpleFontDataCoreText.cpp:34
> > +#if PLATFORM(WX) || PLATFORM(CHROMIUM)
> > +#include <ApplicationServices/ApplicationServices.h>
> > +#else
> >  #include <CoreText/CoreText.h>
> > +#endif
> 
> This is not necessary. ApplicationServices.h can be used everywhere.

I've copied it out of http://trac.webkit.org/browser/trunk/Source/WebCore/platform/graphics/mac/ComplexTextControllerCoreText.mm. I'll fix that file as well.

[Mike West]

Created attachment 173479 [details]
Patch

[WebKit Review Bot]

Comment on attachment 173479 [details]
Patch

Clearing flags on attachment: 173479

Committed r134165: <http://trac.webkit.org/changeset/134165>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.