Bug 101849

Summary: Don't detach from shared ElementAttributeData when overwriting attribute with identical value.
Product: WebKit Reporter: Andreas Kling <kling>
Component: DOMAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Andreas Kling 2012-11-10 14:04:20 PST 
Copy-on-write when nothing actually changes is unfortunate. Let's avoid it.
Comment 1 Andreas Kling 2012-11-10 14:05:15 PST 
Created attachment 173472 [details]
Patch
Comment 2 WebKit Review Bot 2012-11-10 14:36:17 PST 
Comment on attachment 173472 [details]
Patch

Clearing flags on attachment: 173472

Committed r134163: <http://trac.webkit.org/changeset/134163>
Comment 3 WebKit Review Bot 2012-11-10 14:36:21 PST 
All reviewed patches have been landed.  Closing bug.
Comment 4 Ojan Vafai 2012-11-11 21:12:56 PST 
Nice change. This was also a ~7% win on Dromaeo DOMCore attr setAttribute. http://build.chromium.org/f/chromium/perf/chromium-rel-win7-webkit/dromaeo_domcoreattr/report.html?rev=167406&graph=dom_attr_setAttribute&trace=score&history=50
Comment 5 Andreas Kling 2012-11-12 14:47:20 PST 
(In reply to comment #4)
> Nice change. This was also a ~7% win on Dromaeo DOMCore attr setAttribute. http://build.chromium.org/f/chromium/perf/chromium-rel-win7-webkit/dromaeo_domcoreattr/report.html?rev=167406&graph=dom_attr_setAttribute&trace=score&history=50

Oh awesome! Thanks for letting me know :)