Bug 101843

Summary: [GTK] [WebKit2] Move GtkAuthenticationDialog to the UIProcess
Product: WebKit Reporter: Martin Robinson <mrobinson>
Component: WebKitGTKAssignee: Martin Robinson <mrobinson>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Martin Robinson
Reported 2012-11-10 11:11:53 PST
Instead of instantiating the GtkAuthenticationDialog in the WebProcess, where it has its own little GTK+ world, we should instantiate it in the WebProcess. That will allow us to embed it into the WebView in the future.
Attachments
Patch (18.62 KB, patch)
2012-11-10 11:42 PST, Martin Robinson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Martin Robinson
Comment 1 2012-11-10 11:42:34 PST
Created attachment 173463 [details] Patch
WebKit Review Bot
Comment 2 2012-11-16 10:19:04 PST
Comment on attachment 173463 [details] Patch Rejecting attachment 173463 [details] from commit-queue. New failing tests: storage/indexeddb/objectstore-basics.html Full output: http://queues.webkit.org/results/14847843
Martin Robinson
Comment 3 2012-11-16 11:07:15 PST
Comment on attachment 173463 [details] Patch Clearing flags on attachment: 173463 Committed r134974: <http://trac.webkit.org/changeset/134974>
Martin Robinson
Comment 4 2012-11-16 11:07:18 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.