Bug 101825

Summary: Rename the LOG() macro to LOG_INFO()
Product: WebKit Reporter: Dana Jansens <danakj>
Component: New BugsAssignee: Dana Jansens <danakj>
Status: RESOLVED WONTFIX    
Severity: Normal CC: abarth, ap, backer, benjamin, danw, darin, eric.carlson, eric, feature-media-reviews, gustavo, gyuyoung.kim, jamesr, japhet, mifenton, mitz, mjs, mrobinson, mrowe, noam, piman, rakuco, rwlbuis, tonikitoo, webkit.review.bot, yutak
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch darin: review-

Dana Jansens
Reported 2012-11-09 18:09:10 PST
Rename the LOG() macro to LOG_INFO()
Attachments
Patch (462.05 KB, patch)
2012-11-09 18:17 PST, Dana Jansens 		darin: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dana Jansens
Comment 1 2012-11-09 18:17:02 PST
Created attachment 173422 [details] Patch
James Robinson
Comment 2 2012-11-09 18:21:02 PST
This makes sense alongside LOG_ERROR, LOG_VERBOSE, etc. I suspect this might need coordination with the Apple folks if other Apple-internal code is using this macro.
Darin Adler
Comment 3 2012-11-09 18:25:17 PST
Comment on attachment 173422 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173422&action=review > Source/WTF/ChangeLog:9 > + The current macro name conflicts with a macro from the chromium base/ > + library. This conflict makes it very difficult to include headers from But this macro predates the Chromium base library by many years. Chromium should change, not WebKit. > Source/WTF/ChangeLog:14 > + By renaming the macro to LOG_INFO() we avoid conflicts, and give the > + macro a more descriptive name as well. How does “info” make the name more descriptive? Isn’t everything in a computer “information”?
Darin Adler
Comment 4 2012-11-09 18:25:42 PST
(In reply to comment #2) > This makes sense alongside LOG_ERROR, LOG_VERBOSE, etc. I don’t agree.
Alexey Proskuryakov
Comment 5 2012-11-10 19:21:16 PST
Marking WONTFIX per the above discussion.
Note You need to log in before you can comment on or make changes to this bug.