Bug 101800 – Correct scroll adjustment for touchEvent.clientX/clientY

• Component: New Bugs
• Status: RESOLVED FIXED

[Tien-Ren Chen]

Correct scroll adjustment for touchEvent.clientX/clientY

[Tien-Ren Chen]

Created attachment 173373 [details]
Patch

[Adam Barth]

Comment on attachment 173373 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=173373&action=review

> LayoutTests/fast/events/touch/touch-scaled-scrolled.html:17
> +    if (window.internals) {
> +        window.internals.settings.setPageScaleFactor(2, 0, 0);
> +    }

No need for { } here.

> LayoutTests/fast/events/touch/touch-scaled-scrolled.html:30
> +        window.setTimeout(function() { window.testRunner.notifyDone(); }, 0);

Why do we need to use setTimeout?  Can't we call notifyDone from inside touched?

[Tien-Ren Chen]

(In reply to comment #2)
> (From update of attachment 173373 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=173373&action=review
> 
> > LayoutTests/fast/events/touch/touch-scaled-scrolled.html:17
> > +    if (window.internals) {
> > +        window.internals.settings.setPageScaleFactor(2, 0, 0);
> > +    }
> 
> No need for { } here.
> 
> > LayoutTests/fast/events/touch/touch-scaled-scrolled.html:30
> > +        window.setTimeout(function() { window.testRunner.notifyDone(); }, 0);
> 
> Why do we need to use setTimeout?  Can't we call notifyDone from inside touched?

Copy & paste from other test without much thoughts. Will fix the nits. :)

[Tien-Ren Chen]

Created attachment 173379 [details]
Patch

[WebKit Review Bot]

Comment on attachment 173379 [details]
Patch

Clearing flags on attachment: 173379

Committed r134127: <http://trac.webkit.org/changeset/134127>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.