Bug 10177

Summary: REGRESSION: Successfully dragging text into a disabled field
Product: WebKit Reporter: Craig St. Jean <valiantsoul>
Component: FormsAssignee: Nobody <webkit-unassigned>
Status: VERIFIED FIXED    
Severity: Normal CC: mitz, mrowe
Priority: P1 Keywords: Regression
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
Manual test case
none
Patch, including change log, layout test, and a change to DRT to make the test work adele: review+

Craig St. Jean
Reported 2006-07-31 18:12:07 PDT
1) Go to report a new bug 2) Double click UNCONFIRMED 3) Click and hold for a second over it so you can drag 4) Drop it into Assign To (a read-only field) The text will appear in that field now Tested on latest nightly as of 9:10PM Jul 31 2006
Attachments
Manual test case (114 bytes, text/html)
2006-07-31 18:51 PDT, Mark Rowe (bdash) 		no flags
Details
Patch, including change log, layout test, and a change to DRT to make the test work (35.41 KB, patch)
2006-08-01 11:13 PDT, mitz 		adele: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Rowe (bdash)
Comment 1 2006-07-31 18:49:55 PDT
Confirmed with r15718.
Mark Rowe (bdash)
Comment 2 2006-07-31 18:51:34 PDT
Created attachment 9785 [details] Manual test case This manual test case is here so that people with higher privileges within Bugzilla can see the issue. Select the text that says 'Drag me!' and drop it into the text field. The drop should be rejected.
Mark Rowe (bdash)
Comment 3 2006-07-31 22:48:51 PDT
Updating keywords.
mitz
Comment 4 2006-08-01 08:41:21 PDT
Dragging is allowed since the user-modify property of the text field's inner div is set according to the rule element->isReadOnlyControl() ? READ_ONLY : READ_WRITE_PLAINTEXT_ONLY (appearing in two places in RenderTextControl). The fix may be as simple as changing it to element->isReadOnlyControl() || element->disabled() ? READ_ONLY : READ_WRITE_PLAINTEXT_ONLY
mitz
Comment 5 2006-08-01 09:09:24 PDT
Changing bug summary. Read-only fields (having the readonly attribute) actually behave correctly :-)
mitz
Comment 6 2006-08-01 11:13:05 PDT
Created attachment 9794 [details] Patch, including change log, layout test, and a change to DRT to make the test work
Adele Peterson
Comment 7 2006-08-01 11:36:44 PDT
Comment on attachment 9794 [details] Patch, including change log, layout test, and a change to DRT to make the test work looks good, r=me
Darin Adler
Comment 8 2006-08-01 11:37:52 PDT
Comment on attachment 9794 [details] Patch, including change log, layout test, and a change to DRT to make the test work Looks good. r=me
Darin Adler
Comment 9 2006-08-01 11:39:41 PDT
Double review! Twice the fun!
Darin Adler
Comment 10 2006-08-03 08:27:57 PDT
Committed revision 15768.
Note You need to log in before you can comment on or make changes to this bug.