Bug 101760

Summary: [EFL] Turn on error on warnings for "switch"
Product: WebKit Reporter: Laszlo Gombos <laszlo.gombos>
Component: WebKit EFLAssignee: KyungTae Kim <ktf.kim>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, jinwoo7.song, ktf.kim, lucas.de.marchi, rakuco, webkit.review.bot, yael
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Laszlo Gombos
Reported 2012-11-09 07:49:30 PST
Remove "-Wno-error=switch" from Source/cmake/WebKitHelpers.cmake and fix the remaining build errors - if any.
Attachments
Patch (1.32 KB, patch)
2012-11-11 22:39 PST, KyungTae Kim 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
KyungTae Kim
Comment 1 2012-11-11 22:39:31 PST
Created attachment 173559 [details] Patch
KyungTae Kim
Comment 2 2012-11-11 23:03:46 PST
There was no build error after removing "-Wno-error=switch" for EFL build
WebKit Review Bot
Comment 3 2012-11-12 03:21:27 PST
Comment on attachment 173559 [details] Patch Clearing flags on attachment: 173559 Committed r134201: <http://trac.webkit.org/changeset/134201>
WebKit Review Bot
Comment 4 2012-11-12 03:21:32 PST
All reviewed patches have been landed. Closing bug.
Yael
Comment 5 2012-11-12 10:08:11 PST
This broke the build when --no-svg is used.
KyungTae Kim
Comment 6 2012-11-12 18:24:44 PST
(In reply to comment #5) > This broke the build when --no-svg is used. I made a bug for fixing that : https://bugs.webkit.org/show_bug.cgi?id=102027
Note You need to log in before you can comment on or make changes to this bug.