Bug 101718

Summary: DFG should optimize out the NaN check on loads from double arrays if the array prototype chain is having a great time
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, ggaren, mark.lam, mhahnenberg, msaboff, oliver, sam, webkit-ews
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 98606, 101719, 101720    
Bug Blocks:    
Attachments:
Description Flags
work in progress
none
the patch
webkit-ews: commit-queue-
the patch ggaren: review+

Description Filip Pizlo 2012-11-09 00:18:08 PST 
Patch forthcoming.
Comment 1 Filip Pizlo 2012-11-09 00:38:00 PST 
Created attachment 173228 [details]
work in progress
Comment 2 Filip Pizlo 2012-11-10 14:13:00 PST 
Created attachment 173474 [details]
the patch
Comment 3 Early Warning System Bot 2012-11-10 14:19:41 PST 
Comment on attachment 173474 [details]
the patch

Attachment 173474 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/14790581
Comment 4 Early Warning System Bot 2012-11-10 14:21:22 PST 
Comment on attachment 173474 [details]
the patch

Attachment 173474 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/14682467
Comment 5 Filip Pizlo 2012-11-10 14:31:59 PST 
(In reply to comment #4)
> (From update of attachment 173474 [details])
> Attachment 173474 [details] did not pass qt-wk2-ews (qt):
> Output: http://queues.webkit.org/results/14682467

Oops, simple compile error in 32-bit.  Will fix.
Comment 6 Filip Pizlo 2012-11-10 14:46:17 PST 
Created attachment 173477 [details]
the patch
Comment 7 Geoffrey Garen 2012-11-10 15:30:24 PST 
Comment on attachment 173477 [details]
the patch

r=me
Comment 8 Filip Pizlo 2012-11-10 18:56:59 PST 
Landed in http://trac.webkit.org/changeset/134168